Re: [PATCH v2 00/14] ASoC: Intel: avs: Topology and path management

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2022-03-31 3:52 PM, Cezary Rojewski wrote:
> A continuation of avs-driver initial series [1]. This chapter covers
> path management and topology parsing part which was ealier path of the
> main series. The two patches that represented these two subjects in the
> initial series, have been split into many to allow for easier review and
> discussion.
> 
> AVS topology is split into two major parts: dictionaries - found within
> ASoC topology manifest - and path templates.
> 
> Dictionaries job is to reduce the total amount of memory
> occupied by topology elements. Rather than having every pipeline and
> module carry its own information, each refers to specific entry in
> specific dictionary by provided (from topology file) indexes. In
> consequence, most struct avs_tplg_xxx are made out of pointers.
> 
> Path templates are similar to path descriptions found in skylake-driver
> and they describe how given path shall look like in runtime - number of
> modules and pipelines that shape it and how they are laid out. A single
> path template is tied either to FE or BE and thus at most to a single,
> user-visible endpoint when speaking of FE.
> 
> Path is a software representation of its ADSP firmware equivalent. It's
> a logical container for pipelines which are themselves containers - this
> time for modules i.e. processing units.
> Depending on the number of audio formats supported, each path template
> may carry one or more descriptions of given path. During runtime, when
> audio format is known, description matching said format is selected and
> used when instantiating path on ADSP firmware side through IPCs.
> 
> 
> Changes v1 -> v2:
> - fixed 'set but not used' warning in patch 10/14 as mentioned by ikp
>    builder
> 
> 
> Changes RFC -> v1:
> - Plenty of rewordings and spelling fixes as requested by Pierre
> - any sysfs-functionality-related left in RFC dropped, will be part of
>    separate subject in the future
> - separated parsing of formatted strings into: "Support link_mask
>    formatted string" patch, increasing series size to 14 patches
> 
> 
> [1]: https://lore.kernel.org/alsa-devel/20220207122108.3780926-1-cezary.rojewski@intel.com/T/#t


Should I resend this one? Would like to move forward with the follow up 
series so the skylake-driver can be finally replaced :)


Regards,
Czarek