From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: jonathanh@nvidia.com, nicoleotsuka@gmail.com,
alsa-devel@alsa-project.org, atalambedu@nvidia.com,
swarren@nvidia.com, linux-kernel@vger.kernel.org,
spujar@nvidia.com, nwartikar@nvidia.com, lgirdwood@gmail.com,
robh+dt@kernel.org, tiwai@suse.com, viswanathl@nvidia.com,
sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com,
linux-tegra@vger.kernel.org, digetx@gmail.com,
rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [PATCH v4 10/23] ASoC: simple-card: Wrong daifmt for CPU end of DPCM DAI link
Date: Mon, 29 Jun 2020 21:36:49 +0530 [thread overview]
Message-ID: <6e27daa5-331e-968b-4027-2e30aeb7d382@nvidia.com> (raw)
In-Reply-To: <877dvq1yhy.wl-kuninori.morimoto.gx@renesas.com>
On 6/29/2020 6:26 AM, Kuninori Morimoto wrote:
> External email: Use caution opening links or attachments
>
>
> Hi Sameer
>
>> simple-audio-card,dai-link@xxx {
>> format = "i2s";
>> bitclock-master=<&cpu1>;
>> frame-master=<&cpu1>;
>>
>> cpu1: cpu@0 {
>> ...
>> };
>>
>> codec@0 {
>> ...
>> };
>>
>> ...
>> };
>>
>> In above case CPU is expected to be configured as a master and Codec as
>> a slave device. But both CPU/Codec are being configured as slave devices.
>> This happens because asoc_simple_parse_daifmt() uses Codec reference and
>> sets up the 'dai_link->dai_fmt' accordingly while parsing both CPU and
>> Codec.
> I'm sorry but I don't 100% understand about this case...
> asoc_simple_parse_daifmt() should work in this case
>
> The reason why it needs codec node is that
> SND_SOC_DAIFMT_CBx_CFx are "Codec" base Master/Slave.
Currently soc-core has following code snippet,
/snd_soc_runtime_set_dai_fmt() {//
// ...//
//
// if (cpu_dai->component->driver->non_legacy_dai_naming)//
// fmt = inv_dai_fmt;//
//
// ...//
// }/
Above flips polarity for 'cpu_dai' if 'non_legacy_dai_naming' flag is set.
1. Hence example mentioned in the commit message does not work if my
'cpu_dai' driver does not have this flag set.
2. While it is true that we consider reference of 'Codec' mode for
simple CPU<->Codec DAI links, for DPCM this does not seem flexible. For
DPCM links CPU and Codec are not directly connected (CPU<->Dummy or
Dummy<->Codec). Please consider, for example, if the DAI link has
multiple CPU/Codecs. Which 'Codec' reference needs to be considered?
Isn't it better if we explicitly mention which DAI we want to operate as
'Master'?
>
> Thank you for your help !!
>
> Best regards
> ---
> Kuninori Morimoto
next prev parent reply other threads:[~2020-06-29 16:08 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 4:53 [PATCH v4 00/23] Add support for Tegra210 Audio Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 01/23] ASoC: dt-bindings: tegra: Add DT bindings for Tegra210 Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 02/23] ASoC: tegra: Add support for CIF programming Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 03/23] ASoC: tegra: Add Tegra210 based DMIC driver Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 04/23] ASoC: tegra: Add Tegra210 based I2S driver Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 05/23] ASoC: tegra: Add Tegra210 based AHUB driver Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 06/23] ASoC: tegra: Add Tegra186 based DSPK driver Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 07/23] ASoC: tegra: Add Tegra210 based ADMAIF driver Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 08/23] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-06-29 0:38 ` Kuninori Morimoto
2020-06-29 15:46 ` Sameer Pujar
2020-06-30 10:45 ` Mark Brown
2020-06-30 12:56 ` Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 09/23] ASoC: simple-card: Use of_node and DAI names for DAI link names Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 10/23] ASoC: simple-card: Wrong daifmt for CPU end of DPCM DAI link Sameer Pujar
2020-06-29 0:56 ` Kuninori Morimoto
2020-06-29 16:06 ` Sameer Pujar [this message]
2020-06-30 0:56 ` Kuninori Morimoto
2020-06-30 3:47 ` Sameer Pujar
2020-06-30 5:07 ` Kuninori Morimoto
2020-06-27 4:53 ` [PATCH v4 11/23] ASoC: simple-card: Loop over all children for 'mclk-fs' Sameer Pujar
2020-06-29 1:05 ` Kuninori Morimoto
2020-06-29 16:32 ` Sameer Pujar
2020-06-30 2:08 ` Kuninori Morimoto
2020-06-30 4:23 ` Sameer Pujar
2020-06-30 10:55 ` Mark Brown
2020-06-30 11:56 ` Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 12/23] ASoC: simple-card: Support DPCM DAI link with multiple Codecs Sameer Pujar
2020-06-29 1:24 ` Kuninori Morimoto
2020-06-29 17:16 ` Sameer Pujar
2020-06-30 1:24 ` Kuninori Morimoto
2020-06-30 4:08 ` Sameer Pujar
2020-06-30 6:55 ` Kuninori Morimoto
2020-06-30 7:52 ` Sameer Pujar
2020-06-30 11:01 ` Mark Brown
2020-06-30 12:53 ` Sameer Pujar
2020-06-30 15:32 ` Mark Brown
2020-07-02 10:36 ` Sameer Pujar
2020-07-02 12:26 ` Mark Brown
2020-07-17 12:55 ` Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 13/23] ASoC: simple-card: DPCM DAI link direction as per DAI capability Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 14/23] ASoC: soc-core: Probe auxiliary component before others Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 15/23] ASoC: soc-core: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-06-29 1:38 ` Kuninori Morimoto
2020-06-29 17:19 ` Sameer Pujar
2020-06-30 6:07 ` Kuninori Morimoto
2020-06-30 8:03 ` Sameer Pujar
2020-07-02 0:52 ` Kuninori Morimoto
2020-07-02 3:48 ` Sameer Pujar
2020-07-02 8:50 ` Kuninori Morimoto
2020-07-02 9:56 ` Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 16/23] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-06-29 1:41 ` Kuninori Morimoto
2020-06-29 17:29 ` Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 17/23] ASoC: dt-bindings: simple-card: Add compatible for component chaining Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 18/23] ASoC: simple-card: Add support " Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 19/23] arm64: defconfig: Build AHUB component drivers Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 20/23] arm64: defconfig: Enable CONFIG_TEGRA210_ADMA Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 21/23] arm64: tegra: Add DT binding for AHUB components Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 22/23] arm64: tegra: Enable AHUB components on few Tegra platforms Sameer Pujar
2020-06-27 4:53 ` [PATCH v4 23/23] arm64: tegra: Add support for APE sound card on Jetson Nano and TX1 Sameer Pujar
2020-06-30 10:51 ` [PATCH v4 00/23] Add support for Tegra210 Audio Mark Brown
2020-06-30 11:54 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e27daa5-331e-968b-4027-2e30aeb7d382@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox