Re: [PATCH - hda 1/1] ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model

[Alex Murray <murray.alex@gmail.com>]

Patch was supplied here:
https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/337314/comments/148
so no I can't personally confirm it works...

I agree it definitely looks odd - especially compared to the existing
entries... okay I'll see if I can get some more info then and will
repost if I can defintiely confirm it.



2010/1/21 Takashi Iwai <tiwai@suse.de>:
> At Thu, 21 Jan 2010 22:16:26 +1030,
> murray.alex@gmail.com wrote:
>>
>> From: Alex Murray <murray.alex@gmail.com>
>>
>>
>> Signed-off-by: Alex Murray <murray.alex@gmail.com>
>> ---
>>  pci/hda/patch_realtek.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/pci/hda/patch_realtek.c b/pci/hda/patch_realtek.c
>> index 7e0ea37..d044db9 100644
>> --- a/pci/hda/patch_realtek.c
>> +++ b/pci/hda/patch_realtek.c
>> @@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = {
>>        */
>>       SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5),
>>       SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5),
>> +     SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5),
>
> Thanks for the patch.
> But I wonder whether this entry is really correct.  The value looks
> like the codec vendor id.  There you need a PCI SSID.
> Did you confirm that your patch really works?
>
>
> Takashi
>