From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Murray Subject: Re: [PATCH - hda 1/1] ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model Date: Fri, 22 Jan 2010 20:17:03 +1030 Message-ID: <6e7aaa1d1001220147m4c9a8347maadf29affc04447b@mail.gmail.com> References: <4b583eaa.0d0bca0a.753e.37fc@mx.google.com> <6e7aaa1d1001210437g5bad7982p28ad2c424bf0aed5@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-pz0-f179.google.com (mail-pz0-f179.google.com [209.85.222.179]) by alsa0.perex.cz (Postfix) with ESMTP id 76EE624390 for ; Fri, 22 Jan 2010 10:47:19 +0100 (CET) Received: by pzk9 with SMTP id 9so732480pzk.16 for ; Fri, 22 Jan 2010 01:47:18 -0800 (PST) In-Reply-To: <6e7aaa1d1001210437g5bad7982p28ad2c424bf0aed5@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Indeed - turns out is was a config error, and the patch is invalid - thats a bit embarrassing - sorry for the noise. Thanks for looking at it nonetheless. Cheers 2010/1/21 Alex Murray : > Patch was supplied here: > https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/337314/comment= s/148 > so no I can't personally confirm it works... > > I agree it definitely looks odd - especially compared to the existing > entries... okay I'll see if I can get some more info then and will > repost if I can defintiely confirm it. > > > > 2010/1/21 Takashi Iwai : >> At Thu, 21 Jan 2010 22:16:26 +1030, >> murray.alex@gmail.com wrote: >>> >>> From: Alex Murray >>> >>> >>> Signed-off-by: Alex Murray >>> --- >>> =A0pci/hda/patch_realtek.c | =A0 =A01 + >>> =A01 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/pci/hda/patch_realtek.c b/pci/hda/patch_realtek.c >>> index 7e0ea37..d044db9 100644 >>> --- a/pci/hda/patch_realtek.c >>> +++ b/pci/hda/patch_realtek.c >>> @@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[]= =3D { >>> =A0 =A0 =A0 =A0*/ >>> =A0 =A0 =A0 SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5), >>> =A0 =A0 =A0 SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5), >>> + =A0 =A0 SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5), >> >> Thanks for the patch. >> But I wonder whether this entry is really correct. =A0The value looks >> like the codec vendor id. =A0There you need a PCI SSID. >> Did you confirm that your patch really works? >> >> >> Takashi >> >