From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>, alsa-devel@alsa-project.org
Cc: "Cezary Rojewski" <cezary.rojewski@intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] ASoC: Intel: sof_es8336: support a separate gpio to control headphone
Date: Tue, 5 Apr 2022 12:33:40 -0500 [thread overview]
Message-ID: <6eaa459d-b2a9-fc1e-e16d-01b28028462b@linux.intel.com> (raw)
In-Reply-To: <535454c0c598a8454487fe29b164527370e2db81.1649177516.git.mchehab@kernel.org>
> -static const struct acpi_gpio_params speakers_enable_gpio0 = { 0, 0, true };
> +static const struct acpi_gpio_params enable_gpio0 = { 0, 0, true };
> +static const struct acpi_gpio_params enable_gpio1 = { 1, 0, true };
> +
> static const struct acpi_gpio_mapping acpi_speakers_enable_gpio0[] = {
> - { "speakers-enable-gpios", &speakers_enable_gpio0, 1 },
> + { "speakers-enable-gpios", &enable_gpio0, 1 },
> { }
> };
>
> -static const struct acpi_gpio_params speakers_enable_gpio1 = { 1, 0, true };
> static const struct acpi_gpio_mapping acpi_speakers_enable_gpio1[] = {
> - { "speakers-enable-gpios", &speakers_enable_gpio1, 1 },
> + { "speakers-enable-gpios", &enable_gpio1, 1 },
> +};
nit-pick: these changes could be applied to the previous patch.
the rest of the code looks fine, thanks Mauro!
next prev parent reply other threads:[~2022-04-05 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 16:57 [PATCH v3 0/3] Make headphone work on Huawei Matebook D15 Mauro Carvalho Chehab
2022-04-05 16:57 ` [PATCH v3 1/3] ASoC: Intel: sof_es8336: simplify speaker gpio naming Mauro Carvalho Chehab
2022-04-05 16:57 ` [PATCH v3 2/3] ASoC: Intel: sof_es8336: support a separate gpio to control headphone Mauro Carvalho Chehab
2022-04-05 17:33 ` Pierre-Louis Bossart [this message]
2022-04-05 16:57 ` [PATCH v3 3/3] ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eaa459d-b2a9-fc1e-e16d-01b28028462b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox