From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Kevin Lu <kevin-lu@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Shenghao Ding <shenghao-ding@ti.com>,
Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: tas2781: Fix redundant logical jump
Date: Sun, 10 Nov 2024 11:44:19 +0100 [thread overview]
Message-ID: <6ed94ce6-211e-4f6a-9479-34467e6ca7d2@web.de> (raw)
In-Reply-To: <20241025082042.2872-1-tangbin@cmss.chinamobile.com>
> In these functions, some logical jump of "goto" and variable
> are redundant, thus remove them.
Another wording suggestion:
Return some values directly in a few function implementations.
Thus remove local variables which became redundant with this refactoring.
Regards,
Markus
next prev parent reply other threads:[~2024-11-10 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 8:20 [PATCH] ASoC: tas2781: Fix redundant logical jump Tang Bin
2024-11-10 10:44 ` Markus Elfring [this message]
2024-12-02 17:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed94ce6-211e-4f6a-9479-34467e6ca7d2@web.de \
--to=markus.elfring@web.de \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox