From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16540C54E94 for ; Thu, 26 Jan 2023 07:55:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6F423829; Thu, 26 Jan 2023 08:54:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6F423829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674719702; bh=1kryI9fmp/0/7tgRDGf0+gzDLXBckxfaq5aCAfPWxFM=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=gQLt7FapjZiM4o29PfYBV0QeJPqKitOJ3/TGZF8kSF9FAQdII3nwlitTXvxGWKDDb vxyqOEZ8ZwhQy/NvftLtNwqppjKK2ijHRU9bgOHrDNTpthf4yyoU8F/w38x9haFA6q 7G5hPJKfQDZ5uvavpwiv+y3hAVF3i6nBt6L2RD20= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 01667F8025D; Thu, 26 Jan 2023 08:54:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 68EF7F8027D; Thu, 26 Jan 2023 08:54:09 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CAFD7F800AE for ; Thu, 26 Jan 2023 08:54:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CAFD7F800AE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=DagpuqJm DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674719645; x=1706255645; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1kryI9fmp/0/7tgRDGf0+gzDLXBckxfaq5aCAfPWxFM=; b=DagpuqJm8Bt1xKF5IXZqQ2Sb7at2RwfnAS2ISzdAt2zrI7HqCndBQrdi 8GrquUZEwzG1iJJkNdtZgy13AlKUsx5ijeixNe8fVcmoa//kGT21aSYHW 7fWTQ3Qtfo7+4p1xmX2T3kKc0wVX84dvWPHr6lcUVA8u0MEJu3qEwlqT9 aAbxDbEzE60R+66sY/sfs6Q+CrMd9u77Y7Xww/Fzlw1eDnKyo2FblENCw aFOj6yjVXNOX+DnvUn7T63L5t6cXc+bymYTmb++ndfdXs7JoaLOqw4f57 YBTIBDlJLpFcnHpQf/qTAPno7eFATCf5Zm63W5vNf8R43BmYZOA0Bi9fh Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="325430953" X-IronPort-AV: E=Sophos;i="5.97,247,1669104000"; d="scan'208";a="325430953" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 23:54:00 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="805294069" X-IronPort-AV: E=Sophos;i="5.97,247,1669104000"; d="scan'208";a="805294069" Received: from mericx-mobl.ger.corp.intel.com (HELO [10.252.29.93]) ([10.252.29.93]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2023 23:53:56 -0800 Message-ID: <6f0301dd-ce1f-084a-f29b-27bf897804de@linux.intel.com> Date: Thu, 26 Jan 2023 09:54:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/5] ASoC: amd: acp: Refactor i2s clocks programming sequence Content-Language: en-US To: Pierre-Louis Bossart , Venkata Prasad Potturu , broonie@kernel.org, alsa-devel@alsa-project.org References: <20230109132104.1259479-1-venkataprasad.potturu@amd.com> <20230109132104.1259479-4-venkataprasad.potturu@amd.com> <92052eef-3c61-7f3e-75c1-09b76cd38e24@linux.intel.com> From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= In-Reply-To: <92052eef-3c61-7f3e-75c1-09b76cd38e24@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil-kumar.Dommati@amd.com, ssabakar@amd.com, Ajit Kumar Pandey , open list , Basavaraj.Hiregoudar@amd.com, Takashi Iwai , Liam Girdwood , Jia-Ju Bai , Mario Limonciello , Akihiko Odaki , Vijendar.Mukunda@amd.com, V sujith kumar Reddy Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 25/01/2023 19:15, Pierre-Louis Bossart wrote: > This patch adds new Sparse warnings [1]: > > sound/soc/amd/acp/acp-mach-common.c:189:35: error: restricted > snd_pcm_format_t degrades to integer > sound/soc/amd/acp/acp-mach-common.c:333:35: error: restricted > snd_pcm_format_t degrades to integer > sound/soc/amd/acp/acp-mach-common.c:478:35: error: restricted > snd_pcm_format_t degrades to integer > sound/soc/amd/acp/acp-mach-common.c:619:35: error: restricted > snd_pcm_format_t degrades to integer > >> @@ -193,7 +163,11 @@ static int acp_card_rt5682_hw_params(struct snd_pcm_substream *substream, >> struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0); >> struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0); >> int ret; >> - unsigned int fmt; >> + unsigned int fmt, srate, ch, format; >> + >> + srate = params_rate(params); >> + ch = params_channels(params); >> + format = 8 * params_format(params); > > This last line looks suspicious, no? format-to-physical-size conversions > should be using existing macros. not only that, but the "8 * params_format(params)" is certainly not correct for the purpose. params_format() returns SNDRV_PCM_FORMAT_*, which is basically an enum: SNDRV_PCM_FORMAT_S8 0 SNDRV_PCM_FORMAT_S16_LE 2 SNDRV_PCM_FORMAT_S24_LE 6 SNDRV_PCM_FORMAT_S24_3LE 32 SNDRV_PCM_FORMAT_S32_LE 10 include/uapi/sound/asound.h > Should it be > > format = params_physical_width(params); I believe this was the intention. > > ? > > >> + /* Set tdm/i2s1 master bclk ratio */ >> + ret = snd_soc_dai_set_bclk_ratio(codec_dai, ch * format); >> + if (ret < 0) { >> + dev_err(rtd->dev, "Failed to set rt5682 tdm bclk ratio: %d\n", ret); >> + return ret; >> + } >> + >> + if (!drvdata->soc_mclk) { >> + ret = acp_clk_enable(drvdata, srate, ch * format); >> + if (ret < 0) { >> + dev_err(rtd->card->dev, "Failed to enable HS clk: %d\n", ret); >> + return ret; >> + } > > [1] > https://github.com/thesofproject/linux/actions/runs/4005001249/jobs/6874834205 -- Péter