From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oh Eomji <eomji.oh@samsung.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
alsa-devel@alsa-project.org,
open list <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH v1 3/3] sound: usb: Exynos usb audio offloading driver
Date: Fri, 25 Mar 2022 19:44:31 +0100 [thread overview]
Message-ID: <6f2a3a99-0727-cf72-d512-332ca5731568@kernel.org> (raw)
In-Reply-To: <1648109444-196321-4-git-send-email-eomji.oh@samsung.com>
On 24/03/2022 09:10, Oh Eomji wrote:
> This is for usb audio offloading. usb audio offloading processes usb
> audio stream data directly from the audio box even if ap usb enters
> suspend, there is no problem in stream data transmission. This obtains
> power saving effect while using usb audio device.
>
> AP usb and audio usb f/w communicate via AUDIO IPC. By performing AUDIO
> IPC in the vendor operations, abox can access and control the xhci to
> transmit the data directly.
>
> The types of commands and data delivered through AUDIO IPC include the
> following (AP USB <-> AUDIO USB f/w) :
> 1. usb audio connection/disconnection status
> 2. xhci memory information
> 3. full descriptor for usb audio device
> 4. UAC(usb audio class) control command
>
> Signed-off-by: Oh Eomji <eomji.oh@samsung.com>
> ---
> sound/usb/Kconfig | 9 +
> sound/usb/Makefile | 2 +
> sound/usb/exynos_usb_audio.c | 560 +++++++++++++++++++++++++++++++++++++++++++
> sound/usb/exynos_usb_audio.h | 150 ++++++++++++
> 4 files changed, 721 insertions(+)
> create mode 100644 sound/usb/exynos_usb_audio.c
> create mode 100644 sound/usb/exynos_usb_audio.h
Similar pattern as XHCI submission - it looks like you do not work on
mainline kernel, but some other, private tree with other modifications.
It seems you created this series based on that private tree.
This is not the proper process.
Please rebase all your work on recent mainline kernel (v5.18-rc1,
linux-next) and work there.
Then you can start using get_maintainers.pl...
BTW, this v2, not v1, so please version it correctly. Add also changelog
to your series in cover letter.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-25 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220324081208epcas2p41916730b7e386f24e5548fac53e5bc41@epcas2p4.samsung.com>
2022-03-24 8:10 ` [PATCH v1 0/3] Exynos Usb Audio Offloading Support Oh Eomji
2022-03-24 8:10 ` [PATCH v1 1/3] sound: usb: Add vendor's hooking interface Oh Eomji
2022-03-24 8:32 ` Greg Kroah-Hartman
2022-03-25 18:47 ` Krzysztof Kozlowski
2022-03-24 8:33 ` Greg Kroah-Hartman
2022-03-25 6:44 ` Oh Eomji
2022-03-25 6:51 ` Greg Kroah-Hartman
2022-03-25 8:01 ` Christoph Hellwig
2022-03-24 8:10 ` [PATCH v1 2/3] sound: usb: Calling vendor's call-back function within usb audio operation Oh Eomji
2022-03-24 8:34 ` Greg Kroah-Hartman
2022-03-25 7:13 ` Oh Eomji
2022-03-25 7:33 ` Greg Kroah-Hartman
2022-03-24 8:10 ` [PATCH v1 3/3] sound: usb: Exynos usb audio offloading driver Oh Eomji
2022-03-24 8:41 ` Greg Kroah-Hartman
2022-03-28 6:49 ` Oh Eomji
2022-03-25 18:44 ` Krzysztof Kozlowski [this message]
2022-03-28 6:59 ` Oh Eomji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f2a3a99-0727-cf72-d512-332ca5731568@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=eomji.oh@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox