From: Matt Flax <flatmax@flatmax.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Mark Brown" <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-i2c@vger.kernel.org,
kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 603/606] ASoC: codecs: src4xxx-i2c: Convert to i2c's .probe_new()
Date: Sat, 19 Nov 2022 10:01:07 +1100 [thread overview]
Message-ID: <6f431abb-356c-b057-2784-6b5f165a2a2d@flatmax.com> (raw)
In-Reply-To: <20221118224540.619276-604-uwe@kleine-koenig.org>
Reviewed-by: Matt Flax <flatmax@flatmax.com>
On 19/11/22 09:45, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> sound/soc/codecs/src4xxx-i2c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/src4xxx-i2c.c b/sound/soc/codecs/src4xxx-i2c.c
> index 43daa9dc8ab5..27026030704a 100644
> --- a/sound/soc/codecs/src4xxx-i2c.c
> +++ b/sound/soc/codecs/src4xxx-i2c.c
> @@ -12,8 +12,7 @@
>
> #include "src4xxx.h"
>
> -static int src4xxx_i2c_probe(struct i2c_client *i2c,
> - const struct i2c_device_id *id)
> +static int src4xxx_i2c_probe(struct i2c_client *i2c)
> {
> return src4xxx_probe(&i2c->dev,
> devm_regmap_init_i2c(i2c, &src4xxx_regmap_config), NULL);
> @@ -37,7 +36,7 @@ static struct i2c_driver src4xxx_i2c_driver = {
> .name = "src4xxx",
> .of_match_table = of_match_ptr(src4xxx_of_match),
> },
> - .probe = src4xxx_i2c_probe,
> + .probe_new = src4xxx_i2c_probe,
> .id_table = src4xxx_i2c_ids,
> };
> module_i2c_driver(src4xxx_i2c_driver);
next prev parent reply other threads:[~2022-11-18 23:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:42 ` [PATCH 437/606] mfd: madera-i2c: Convert to i2c's .probe_new() Uwe Kleine-König
2022-11-21 9:36 ` Charles Keepax
2022-11-18 22:45 ` [PATCH 597/606] ALSA: aoa: onyx: " Uwe Kleine-König
2022-11-19 8:44 ` Takashi Iwai
2022-11-18 22:45 ` [PATCH 598/606] ALSA: aoa: tas: " Uwe Kleine-König
2022-11-19 8:45 ` Takashi Iwai
2022-11-18 22:45 ` [PATCH 599/606] ALSA: hda: cs35l41: " Uwe Kleine-König
2022-11-19 8:45 ` Takashi Iwai
2022-11-18 22:45 ` [PATCH 600/606] ALSA: ppc: keywest: " Uwe Kleine-König
2022-11-19 8:45 ` Takashi Iwai
2022-11-18 22:45 ` [PATCH 601/606] ASoC: codecs: es8326: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 602/606] ASoC: max98396: " Uwe Kleine-König
2022-11-18 22:45 ` [PATCH 603/606] ASoC: codecs: src4xxx-i2c: " Uwe Kleine-König
2022-11-18 23:01 ` Matt Flax [this message]
2022-11-18 22:45 ` [PATCH 604/606] ASoC: codecs: tas2780: " Uwe Kleine-König
2022-11-19 6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
2022-11-19 6:50 ` patchwork-bot+chrome-platform
2022-11-19 11:10 ` Wolfram Sang
2022-11-20 19:43 ` Sebastian Reichel
2022-11-21 9:53 ` Lee Jones
2022-11-22 18:58 ` Jonathan Cameron
2022-11-22 20:16 ` Uwe Kleine-König
2022-11-26 15:43 ` Andy Shevchenko
2022-11-23 12:11 ` (subset) " Mark Brown
2022-11-23 17:23 ` Mark Brown
2022-11-24 12:27 ` Mark Brown
2022-11-24 13:26 ` Mark Brown
2022-11-24 13:50 ` Mark Brown
2022-11-24 14:03 ` Mark Brown
2022-11-24 14:28 ` Mark Brown
2022-11-24 15:15 ` Mark Brown
2022-11-24 15:26 ` Mark Brown
2022-11-24 15:38 ` Mark Brown
2022-11-24 15:49 ` Mark Brown
2022-11-24 16:04 ` Mark Brown
2022-11-25 14:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f431abb-356c-b057-2784-6b5f165a2a2d@flatmax.com \
--to=flatmax@flatmax.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox