From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 685DEC4BA24 for ; Wed, 26 Feb 2020 19:05:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E80F32072D for ; Wed, 26 Feb 2020 19:05:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jitI9tUs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E80F32072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 54139825; Wed, 26 Feb 2020 20:04:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 54139825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582743917; bh=JMkMnM5TNpPd1h+fFlxD1Cnd3lPomMzPYEioV22q3/U=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jitI9tUsFa6p92yZ5YcZ3HjOSvYm7ryessYEODp8l5sBMFVpfuIBvKjdHHknJ/ghC qnWW0zionjeTGy63kVKsSnKPawhfaDT5QlPMslPvCI5/wrX0zntEtbCJ5vaXk4JAyJ wF8O6ikFxQoLAjwm+Jpt4ifzz4Z+K6voizQ/3R3U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CF987F8014D; Wed, 26 Feb 2020 20:04:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A3741F8014E; Wed, 26 Feb 2020 20:04:25 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6398CF800AD for ; Wed, 26 Feb 2020 20:04:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6398CF800AD X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 11:04:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,489,1574150400"; d="scan'208";a="271853059" Received: from terrellb-mobl1.amr.corp.intel.com (HELO [10.254.114.82]) ([10.254.114.82]) by fmsmga002.fm.intel.com with ESMTP; 26 Feb 2020 11:04:18 -0800 Subject: Re: [PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply To: Kuninori Morimoto , Mark Brown References: <87eeuh97k4.wl-kuninori.morimoto.gx@renesas.com> <875zft97i4.wl-kuninori.morimoto.gx@renesas.com> From: Pierre-Louis Bossart Message-ID: <704a2cb1-ebcd-d433-0b8a-0f8d97d72fa5@linux.intel.com> Date: Wed, 26 Feb 2020 13:04:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <875zft97i4.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2/26/20 12:40 AM, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > DAI is counting its activity, and both playback/capture directional > activity. When considering mute, DAI's activity is enough instead of > caring both playback/capture. > This patch makes mute check simply. > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/soc-pcm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > index 4a14f10b8c90..7e0464ec802e 100644 > --- a/sound/soc/soc-pcm.c > +++ b/sound/soc/soc-pcm.c > @@ -1202,7 +1202,6 @@ static int soc_pcm_hw_free(struct snd_pcm_substream *substream) > struct snd_soc_pcm_runtime *rtd = substream->private_data; > struct snd_soc_dai *cpu_dai; > struct snd_soc_dai *codec_dai; > - bool playback = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; > int i; > > mutex_lock_nested(&rtd->card->pcm_mutex, rtd->card->pcm_subclass); > @@ -1226,11 +1225,7 @@ static int soc_pcm_hw_free(struct snd_pcm_substream *substream) > > /* apply codec digital mute */ > for_each_rtd_codec_dai(rtd, i, codec_dai) { > - int playback_active = codec_dai->stream_active[SNDRV_PCM_STREAM_PLAYBACK]; > - int capture_active = codec_dai->stream_active[SNDRV_PCM_STREAM_CAPTURE]; > - > - if ((playback && playback_active == 1) || > - (!playback && capture_active == 1)) > + if (codec_dai->active == 1) nit-pick: we have two tests in soc-pcm.c if (codec_dai->active) if (codec_dai->active == 1) The two are functionality equivalent but it'd be good to choose one version - or possibly use 'active' as a boolean. > snd_soc_dai_digital_mute(codec_dai, 1, > substream->stream); > } >