From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH] ASoC: pcm: send DAPM_STREAM_STOP event in dpcm_fe_dai_shutdown
Date: Sat, 5 Dec 2020 18:08:02 +0100 [thread overview]
Message-ID: <7053e79c-7b68-c04e-73de-bc6efdbf27b9@redhat.com> (raw)
In-Reply-To: <20201203143117.GF4700@sirena.org.uk>
Hi,
On 12/3/20 3:31 PM, Mark Brown wrote:
> On Wed, Dec 02, 2020 at 11:33:43AM -0800, Ranjani Sridharan wrote:
>> A recent change removed the call to send the DAPM_STREAM_STOP
>> event in dpcm_fe_dai_shutdown. But this causes a regression
>> when a PCM prepare is not paired with a hw_free. So, add
>> the DAPM_STREAM_STOP event back to dpcm_fe_dai_shutdown()
>> to fix this.
>
> Hans, does this fix the issue you were seeing?
Yes I can confirm that this fixes the errors which I was seening with asoc/for-5.11:
Tested-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
next prev parent reply other threads:[~2020-12-05 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 19:33 [PATCH] ASoC: pcm: send DAPM_STREAM_STOP event in dpcm_fe_dai_shutdown Ranjani Sridharan
2020-12-03 14:31 ` Mark Brown
2020-12-05 17:08 ` Hans de Goede [this message]
2020-12-07 17:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7053e79c-7b68-c04e-73de-bc6efdbf27b9@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).