From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4DB8C001DE for ; Mon, 31 Jul 2023 05:41:36 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 847A1827; Mon, 31 Jul 2023 07:40:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 847A1827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690782094; bh=qxFz2UwvnFHJYzgei+xCEu7KR04+AmG77qcHQUxmLjY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=HeofivZN/rXzt6W9TPPktoivdcN3RYUDyZUpee0HhhgUcykITPiC+GsRqviD5ap+R uFAvqt7TdF1HbBVFY4slXnLSvEnOuQYqLlKw3Gvc85+CGXSXWMALMM1UeBXDRH2wpt 2S5PuXT316Lhk4Sn7tc8hlr3347iYz1l324UU/8U= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 12A12F8015B; Mon, 31 Jul 2023 07:40:21 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8ECE6F8016D; Mon, 31 Jul 2023 07:40:21 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4DDF6F8016D; Mon, 31 Jul 2023 07:40:15 +0200 (CEST) Received: from mgamail.intel.com (unknown [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BF8AFF80149 for ; Mon, 31 Jul 2023 07:40:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BF8AFF80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=aBhTH211 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690782008; x=1722318008; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=qxFz2UwvnFHJYzgei+xCEu7KR04+AmG77qcHQUxmLjY=; b=aBhTH211kBoVKHSdlcyFYTUUwYoRIEgDoeGeQ5s8TeDqS+TXximPKC83 89T6Msc6f96FobY8OesbWg6QzwJ5FtLojQqaUrjlGGDEDJvEnCTYEoQvf zwgQcT6GSesnGLH/G6OxcBSs/Vjv7L/2z/4RGnVyYLDL127jtqGd89TnW yFo856YAqaOBgRnkTtULPJfRqZdZmgtu2Qi28tBrXUBm5wqsFgdxgjS7X 1O63mybnUdCZqK2y7oZ44rffsTPzwvn/WcmPs1BX0GfmZ+BUq9tHalbQp Iz4KqSpHA8Pb2G1TZgKV77X85E8MmLJJVUiv74Ms/KoA6RGlcpdC2SYJ3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10787"; a="368938066" X-IronPort-AV: E=Sophos;i="6.01,243,1684825200"; d="scan'208";a="368938066" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2023 22:40:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10787"; a="678193915" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="678193915" Received: from yungchua-mobl2.ccr.corp.intel.com (HELO [10.92.2.114]) ([10.92.2.114]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2023 22:40:00 -0700 Message-ID: <70ff624f-75d3-d6b1-e709-97d7c75ea3da@linux.intel.com> Date: Mon, 31 Jul 2023 13:39:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 1/1] ASoC: Intel: maxim-common: get codec number from ACPI table Content-Language: en-US To: Brent Lu , alsa-devel@alsa-project.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, Ajye Huang , Yong Zhi , Terry Cheong , Uday M Bhat , Mac Chiang , "Dharageswari . R" , Kuninori Morimoto , ye xingchen , Andy Shevchenko References: <20230731103419.2536036-1-brent.lu@intel.com> <20230731103419.2536036-2-brent.lu@intel.com> From: "Liao, Bard" In-Reply-To: <20230731103419.2536036-2-brent.lu@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: TRE2GVYEG5WLHPKT455LJN6ZPI3WZTVO X-Message-ID-Hash: TRE2GVYEG5WLHPKT455LJN6ZPI3WZTVO X-MailFrom: yung-chuan.liao@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/31/2023 6:34 PM, Brent Lu wrote: > We implement a helper function to get number of codecs from ACPI > subsystem instead of using quirk flag in machine driver. Also refactor > module interface by adding max_98390_dai_link() function. > > On the sof_rt5682 machine driver side, we remove the quirk flag > SOF_MAX98390_TWEETER_SPEAKER_PRESENT and use the new interface of > max98390 to setup dai link. > > Signed-off-by: Brent Lu Looks good to me. Reviewed-by: Bard Liao