From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F2A8C10F1A for ; Thu, 9 May 2024 19:57:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5392EC7; Thu, 9 May 2024 21:56:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5392EC7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1715284618; bh=yggsdWvGecv9KlZXR7Gn5ZXJpoT8aeY02OM9eHlbgFI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=LrhlNtrRVYjzBv9u+PbzMNjCUTa4U2EU9w4/rF0mljOBIJg0Vv4iMvdCdCUYlGWzM 5d4YJN647BgNY+bCDzqBZynnqOWaMhP78KJytp227zyjAcduO0b1IxOuG/oT039qz6 78faRQKY0UWP+zqtXA52+sSyxsRRR2oCKU9rEFk0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EFD65F805A0; Thu, 9 May 2024 21:56:26 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2ACFEF8049C; Thu, 9 May 2024 21:56:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2821FF8049C; Thu, 9 May 2024 21:56:21 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 54EFFF80152 for ; Thu, 9 May 2024 21:56:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 54EFFF80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=HdUPgF1P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715284580; x=1746820580; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yggsdWvGecv9KlZXR7Gn5ZXJpoT8aeY02OM9eHlbgFI=; b=HdUPgF1PecVKfALigX/Gud7/HDOt/esxgUAzOLuNRTjQatccpid2Hhnm myws8iVvt6KsHpLmskWduzwYAsqkiAdJvOVekxcnk4P5iS71K0237MFzi dUvebEi3hi7fv4iq1okcY+cmRJ1Bwy/b0nk5xB5nmYzrWap0dnu55s8nm FqWt9kpJgtR0HMdW7Ie0+ZtRWNqBW6uhxz9m3KaCTBeAGgGQRZPqWypfY 4cOKkv+GR7JG2uP7LWS0rHkrHHBtnS+xiMRW7Bbjyd5Kninn3BEkr9ArT TPN+rKRbwgDESrXWAYVHVZqBChxBhrbRFmYhcfqJC0xziHGLTetp35OJk Q==; X-CSE-ConnectionGUID: M+Nuhb7GRzOLpucJH8sHsg== X-CSE-MsgGUID: 3D2WyGdoTLCPRyZplbGFLg== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="11454252" X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="11454252" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 12:56:14 -0700 X-CSE-ConnectionGUID: 0hSRX4lDS5GfwWSqiwJzxQ== X-CSE-MsgGUID: Ld9aKcU1TYSOY0PDBQNl8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="34213064" Received: from ajunnare-mobl.amr.corp.intel.com (HELO [10.213.181.85]) ([10.213.181.85]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 12:56:11 -0700 Message-ID: <726e7006-30b4-4525-84c8-4fb2ef380994@linux.intel.com> Date: Thu, 9 May 2024 07:54:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 09/39] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp To: Wesley Cheng , srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, perex@perex.cz, conor+dt@kernel.org, corbet@lwn.net, lgirdwood@gmail.com, andersson@kernel.org, krzk+dt@kernel.org, gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, broonie@kernel.org, bgoswami@quicinc.com, tiwai@suse.com, bagasdotme@gmail.com, robh@kernel.org, konrad.dybcio@linaro.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, alsa-devel@alsa-project.org References: <20240507195116.9464-1-quic_wcheng@quicinc.com> <20240507195116.9464-10-quic_wcheng@quicinc.com> <9bd1ec72-71ea-4a1c-b795-af6e7687ca07@linux.intel.com> <0a4d7c2b-ac7d-7bd4-f97e-db60944a1d39@quicinc.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <0a4d7c2b-ac7d-7bd4-f97e-db60944a1d39@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID-Hash: GPQXNDZV4UNBEMFFAOPINIFPSKYZZFDL X-Message-ID-Hash: GPQXNDZV4UNBEMFFAOPINIFPSKYZZFDL X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: >> Wait, is this saying you will have exactly one PCM device/FE DAI >> connected to the USB BE DAI exposed in patch 11? >> >>> +    SND_SOC_DAPM_MIXER("USB Mixer", SND_SOC_NOPM, 0, 0, >>> +               usb_mixer_controls, >>> +               ARRAY_SIZE(usb_mixer_controls)), >>> + >> >> And then what is the role of the USB mixer if you only have one input? >> >> I must be missing something. >> > > Not sure if this is a QCOM specific implementation, but the way the DT > is defined for the USB offload path is as follows: > >     usb-dai-link { >         link-name = "USB Playback"; > >         cpu { >             sound-dai = <&q6afedai USB_RX>; >         }; > >         codec { >             sound-dai = <&usbdai USB_RX>; >         }; > >         platform { >             sound-dai = <&q6routing>; >         }; >     }; > > Based on our DT parser helper API (qcom_snd_parse_of()) this isn't going > to create a PCM device.  The PCM devices are created for nodes that > don't have a codec and platform defined: > >     mm1-dai-link { >         link-name = "MultiMedia1"; >         cpu { >             sound-dai = <&q6asmdai      MSM_FRONTEND_DAI_MULTIMEDIA1>; >         }; >     }; > > The ASM path is the entity that defines the number of PCM devices that > is created for the QC ASoC platform card, and is where the actual PCM > data is sent over to the DSP.  So there could be several PCM devices > that can use the USB BE DAI. ok, but then how would this work with the ALSA controls reporting which PCM device can be used? I didn't see a mechanism allowing for more than one offloaded device, IIRC the control reported just ONE PCM device number.