public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Jack Yu <jack.yu@realtek.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"Flove(HsinFu)" <flove@realtek.com>,
	"Oder Chiou" <oder_chiou@realtek.com>,
	"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH] ASoC: rt1320-sdw: kcontrol for brown-out feature switch
Date: Wed, 1 Apr 2026 13:11:14 +0000	[thread overview]
Message-ID: <72d466aade174c82ba5eabe898906231@realtek.com> (raw)
In-Reply-To: <28496ff7e8274da0a9b2471de20cda5e@realtek.com>

> > diff --git a/sound/soc/codecs/rt1320-sdw.h b/sound/soc/codecs/rt1320-sdw.h
> > index 5a9f496dd848..4a1d3fc4c8ee 100644
> > --- a/sound/soc/codecs/rt1320-sdw.h
> > +++ b/sound/soc/codecs/rt1320-sdw.h
> > @@ -159,6 +159,7 @@ struct rt1320_sdw_priv {
> >          bool hw_init;
> >          bool first_hw_init;
> >          int version_id;
> > +       int brown_out;
> >          unsigned int dev_id;


> Could you set brown_out to 1 by default?
> The blind write enables brown-out by default.

Sorry, I misunderstood.
LGTM.

Reviewed-by: Shuming Fan <shumingf@realtek.com>
      

  reply	other threads:[~2026-04-01 13:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  9:31 [PATCH] ASoC: rt1320-sdw: kcontrol for brown-out feature switch jack.yu
2026-04-01 13:02 ` Shuming [范書銘]
2026-04-01 13:11   ` Shuming [范書銘] [this message]
2026-04-01 13:23 ` Mark Brown
2026-04-02  4:37   ` Jack Yu
2026-04-02 11:14     ` Mark Brown
2026-04-07  3:48 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72d466aade174c82ba5eabe898906231@realtek.com \
    --to=shumingf@realtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox