From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugtrack@alsa-project.org Subject: [ALSA - driver 0001208]: 2 Typos and a little Question to device.c Date: Thu, 23 Jun 2005 12:14:24 +0200 Message-ID: <748fc00dbd12dbbed98cbb3ebc98272d@bugtrack.alsa-project.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bugtrack.alsa-project.org (gate.perex.cz [82.113.61.162]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id 3A47421A for ; Thu, 23 Jun 2005 12:14:24 +0200 (MEST) Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org A NOTE has been added to this issue. ====================================================================== ====================================================================== Reported By: Henne Assigned To: ====================================================================== Project: ALSA - driver Issue ID: 1208 Category: 1_OTHERS Reproducibility: always Severity: text Priority: normal Status: new Distribution: Kernel Version: ====================================================================== Date Submitted: 06-22-2005 23:58 CEST Last Modified: 06-23-2005 12:14 CEST ====================================================================== Summary: 2 Typos and a little Question to device.c Description: The comment @type of snd_device_new() is wrong. I belive it has to be SNDDRV_DEV_XXX instead of SNDDRV_DEV_TYPE_XXX . The comment in snd_device_disconnect() has to be snd_device_disconnect instead of snd_device_free. The sound_assert() macros in snd_device_new() and snd_device_register() have a couple of expessions, and I belive it would be better for debuggin if the macro calls would be called for paramter seperately, like in all the other functions. ====================================================================== ---------------------------------------------------------------------- tiwai - 06-23-05 10:50 ---------------------------------------------------------------------- Agreed. Patches are welcome :) (See NEWS section for the detail how to write a patch.) ---------------------------------------------------------------------- Henne - 06-23-05 12:14 ---------------------------------------------------------------------- Here we go! Issue History Date Modified Username Field Change ====================================================================== 06-22-05 23:58 Henne New Issue 06-23-05 10:50 tiwai Note Added: 0005166 06-23-05 12:12 Henne File Added: device-patch.diff 06-23-05 12:14 Henne Note Added: 0005179 ====================================================================== ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click