From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@kernel.org>,
Bard liao <yung-chuan.liao@linux.intel.com>
Subject: Re: Asoc: Intel: SST (CHT) regression in asoc/for-5.11
Date: Tue, 01 Dec 2020 15:52:00 -0800 [thread overview]
Message-ID: <7581c05d22412dcd2bd7174960b7d9214d390d35.camel@linux.intel.com> (raw)
In-Reply-To: <s5hpn3tbimq.wl-tiwai@suse.de>
> > Hi Pierre/Takashi,
> >
> > The DAPM_STREAM_START event is still there in soc_pcm_prepare() and
> > this patch only removed the duplicate call in
> > dpcm_fe_dai_prepare().
>
> Ah, thanks, I see now.
>
> But note that the PCM prepare callback may be called multiple times
> in
> row; i.e. it's not always paired with hw_clean (that is via either
> hw_params error path or hw_free). So if the balance really matters,
> we need another type of checks, not relying on the call pattern.
Hi Takashi,
It seems like it is indeed a problem with prepare not being paired with
hw_free. Adding the stream_stop() event back to dpcm_fe_dai_shutdown()
as it was before seems to resolve the issue. I am running further tests
to confirm it doesnt have adverse effects on SOF. Will post the patch
shortly.
Thanks,
Ranjani
prev parent reply other threads:[~2020-12-01 23:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 12:24 Asoc: Intel: SST (CHT) regression in asoc/for-5.11 Hans de Goede
2020-11-30 16:15 ` Pierre-Louis Bossart
2020-12-01 3:24 ` Pierre-Louis Bossart
2020-12-01 14:46 ` Takashi Iwai
2020-12-01 15:37 ` Hans de Goede
2020-12-01 16:15 ` Ranjani Sridharan
2020-12-01 16:23 ` Takashi Iwai
2020-12-01 23:52 ` Ranjani Sridharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7581c05d22412dcd2bd7174960b7d9214d390d35.camel@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).