From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 025DEC77B7D for ; Wed, 17 May 2023 16:50:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 11CF61F7; Wed, 17 May 2023 18:50:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 11CF61F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684342256; bh=KS6uI5RGH1xHM6b9lrfHL7GS8cXP0VR3O3NP1UIgCzg=; h=Date:Subject:To:References:From:In-Reply-To:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=rdm3Cw0QI36/dobhKVeDDR8UCDBpIh7ra2dFCYX7VKUzq0x1ajxJWn/ZJQTWHq785 kiEy0FWM4/JdY0Njaxmd+T/mpKlEr/p2AJCBEI5+gojEYlz+CMbR2srWTtL56Ile7i 7Bm+crTzIWwhmO4Uz2HUPehBJgtznX0nGipxJPcI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A8153F80549; Wed, 17 May 2023 18:50:05 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D7135F802E8; Wed, 17 May 2023 18:50:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D153FF802E8; Wed, 17 May 2023 18:49:59 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 98223F8016D for ; Wed, 17 May 2023 18:49:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 98223F8016D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=B/ksu3tT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684342198; x=1715878198; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=KS6uI5RGH1xHM6b9lrfHL7GS8cXP0VR3O3NP1UIgCzg=; b=B/ksu3tTMwohDTVaVdWVIatwC6jQebuM7YoMdnbpqRATvUDlgXXKS5xZ XzlF//2XF6mE1bN6F/8+wsT7bBdFZCKzB5nh9s21uKFYGc+pTkn8fNdZM z7Yq0Gz8rhceoqqU6fuyB5DGbK3eIduUG/G2AaE7HxMk+/N6SkQf9LZKU ZglV+a5YhmACXoo7P4AwC2FgVVz+te1p2VNtiTBXt4s5f1W+JllmBi+3n 6xHpUaQmOyEnmwtV7+/lKWg4pDqG7OuVjHBHbA48MS24tyuxpjoCVFWMe sflpbMvp5CgnxSbeRDUL43iQ0KkM8rkiBwnaXW+ViwkRGF4V+2Q3voB0T A==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="350649322" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="350649322" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 09:48:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="734764313" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="734764313" Received: from pgopdahl-mobl1.amr.corp.intel.com (HELO [10.209.16.196]) ([10.209.16.196]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 09:48:47 -0700 Message-ID: <7638419f-7df1-a31a-e68e-1c315f57cabf@linux.intel.com> Date: Wed, 17 May 2023 11:45:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.0 Subject: Re: [PATCH] soundwire: qcom: add proper error paths in qcom_swrm_startup() Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Bard Liao , Sanyog Kale , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20230517163736.997553-1-krzysztof.kozlowski@linaro.org> From: Pierre-Louis Bossart In-Reply-To: <20230517163736.997553-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: K7EHFSL3UTOHNK6BHI6SIHCR3HDTJDTM X-Message-ID-Hash: K7EHFSL3UTOHNK6BHI6SIHCR3HDTJDTM X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/17/23 11:37, Krzysztof Kozlowski wrote: > Reverse actions in qcom_swrm_startup() error paths to avoid leaking > stream memory and keeping runtime PM unbalanced. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart