From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A20D8C43334 for ; Thu, 9 Jun 2022 16:22:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 28BB01ACD; Thu, 9 Jun 2022 18:21:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 28BB01ACD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1654791759; bh=0CsSwkvejVm3bVTO7Azc2brKlKE9Yji53qGgFJwL8DY=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aHng32SNL376EnCBtwlIGNIpCScUgj8lxQCgER4rthPhbAoqTeIb788RE+cTVoTKV OfB2Pgk1azFIsTTn3MWHzQdMrCt8XJvEfie1ST0VTQqGLo8bT3Sqhcvf330E9SF8j6 awrOxe97GukJWiN7qIuOTCIVJOhHVGU2FvV8SOco= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C8A0FF8012F; Thu, 9 Jun 2022 18:21:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 694D7F800E9; Thu, 9 Jun 2022 18:21:47 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0490CF800E9 for ; Thu, 9 Jun 2022 18:21:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0490CF800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bp+rtrcL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654791700; x=1686327700; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0CsSwkvejVm3bVTO7Azc2brKlKE9Yji53qGgFJwL8DY=; b=bp+rtrcLWDG7LW4u4K18RCYpn0Bqomj1UxSCwQj9zw7BNnSUJRVludIP vsXp3QNOE24Li8JafPc+2ah52RB97X8D83ujfBs8Umx9232WnUqqV05js f1vNHB27yTijYVRsIfxrHzFylfCP1JdIl5JJfYAODXYsPW30LAGNLxhDv BgNjfW8dlqlBnvcRBwYpO44tt5/vIIzKgVenPHMQaH5TW2MC49dzqDYhy dRDUyXJAiFeSDqnlGwYbNYcxeKgB4Qhf5VeMixkqZf2yZeJWAg6k+lyS7 7qY+JeuFrhzlYGfyApP1lxVv1F9AViagyGXmqaWX39iXGHR4NDha3yTBM A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="302708257" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="302708257" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 09:21:34 -0700 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="585661484" Received: from jeremywe-mobl3.amr.corp.intel.com (HELO [10.209.173.145]) ([10.209.173.145]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 09:21:33 -0700 Message-ID: <7652ddab-53a5-ac8e-33f5-d25527acb1a6@linux.intel.com> Date: Thu, 9 Jun 2022 11:21:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH v1 14/16] soundwire: Use acpi_dev_for_each_child() Content-Language: en-US To: "Rafael J. Wysocki" References: <1843211.tdWV9SEqCh@kreacher> <5296779.Sb9uPGUboI@kreacher> <63d7f3ed-b5a9-c869-5d25-a33a1d4e63c8@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux PM , Bard Liao , "Rafael J. Wysocki" , LKML , Linux ACPI , Vinod Koul , Hans de Goede , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Mika Westerberg X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with >> >> return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus); > > Sure, I'll do that. Thanks! I also added this EXPORT_SYMBOL to work-around link errors, not sure if this is in your tree already? diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 86fa61a21826c..ade6259c19af6 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -1113,6 +1113,7 @@ int acpi_dev_for_each_child(struct acpi_device *adev, return device_for_each_child(&adev->dev, &adwc, acpi_dev_for_one_check); } +EXPORT_SYMBOL_GPL(acpi_dev_for_each_child);