From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v1] ASoC: Intel: Skylake: Switch to modern UUID API
Date: Fri, 21 Jun 2019 05:41:48 +0200 [thread overview]
Message-ID: <76ae3d0e-a948-f8f9-d6af-13c523414352@linux.intel.com> (raw)
In-Reply-To: <20190620150907.GG9224@smile.fi.intel.com>
>>> char mod_name[64]; /* guid str = 32 chars + 4 hyphens */
>>> - uuid_le *uuid_mod;
>>> - uuid_mod = (uuid_le *)guid;
>>> snprintf(mod_name, sizeof(mod_name), "%s%pUL%s",
>>> - "intel/dsp_fw_", uuid_mod, ".bin");
>>> + "intel/dsp_fw_", guid, ".bin");
>>
>> indentation looks off, not sure if this is a diff effect.
>
> Ah, this can be modified to the below (by a separate patch, since Mark applied
> this one already):
>
> snprintf(mod_name, sizeof(mod_name), "intel/dsp_fw_%pUL.bin", guid);
>
> What do you think?
>
> P.S. And it will take only one line.
Sounds good to me. Not sure why it was written this way.
next prev parent reply other threads:[~2019-06-21 3:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 15:02 [PATCH v1] ASoC: Intel: Skylake: Switch to modern UUID API Andy Shevchenko
2019-06-19 15:46 ` Pierre-Louis Bossart
2019-06-20 15:09 ` Andy Shevchenko
2019-06-21 3:41 ` Pierre-Louis Bossart [this message]
2019-06-24 8:51 ` Amadeusz Sławiński
2019-06-25 17:15 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2018-07-16 9:52 Andy Shevchenko
2019-01-07 15:55 ` Andy Shevchenko
2019-01-07 16:33 ` Pierre-Louis Bossart
2019-01-07 17:24 ` Andy Shevchenko
2019-01-21 8:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76ae3d0e-a948-f8f9-d6af-13c523414352@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).