From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68CABC48BE8 for ; Wed, 16 Jun 2021 19:12:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06C4F61246 for ; Wed, 16 Jun 2021 19:12:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06C4F61246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C274516E6; Wed, 16 Jun 2021 21:11:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C274516E6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623870738; bh=Djd1xykuIfQ4AlzslrkGdUb2vW2c43W7oNkeoBmUFjs=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=G57+FWpLLuuTaUJPT5kpFS/QAt4MP0RFBsz1DAsQUWJ72ADhv2LjbXH3E5qM2PKVe UGQo1uA8Dz9Xm1tLK6D5JjSWc58aJLQPzWQWHsrgF/Unj09XGBg/e8TqjKOoRb8gDN XdOI95ESgK05rRjnkpPV1tNO50WGbPUJ2xvJ0y8U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4BB9BF802E8; Wed, 16 Jun 2021 21:11:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 01432F80423; Wed, 16 Jun 2021 21:11:25 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2D3E5F8028B for ; Wed, 16 Jun 2021 21:11:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2D3E5F8028B IronPort-SDR: G3lATC8EiNG3XOCq4V1Rbd0A5Ejf0pfk6MRaltHtaog9+rmTWV3WxfCweytN2AazaQ5F0MawTo g7dLdbNN8/kQ== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="206199498" X-IronPort-AV: E=Sophos;i="5.83,278,1616482800"; d="scan'208";a="206199498" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 12:11:17 -0700 IronPort-SDR: n6zRFDrwjIzQ47702ClxTmPuOe3ZO+JXUoWxQtosamnGyR9/uvZ608qFuQhnMUaTWvtcZYsAfp Ft5a6WSHOxlg== X-IronPort-AV: E=Sophos;i="5.83,278,1616482800"; d="scan'208";a="640104279" Received: from mindylam-mobl1.amr.corp.intel.com (HELO [10.213.182.47]) ([10.213.182.47]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 12:11:14 -0700 Subject: Re: [PATCH] ASoC: max98357a: set channels_max to 4 To: Cheng-yi Chiang References: <20210526154704.114957-1-judyhsiao@chromium.org> <3501e398-dfba-43b1-4638-325a158e860d@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <7748e621-ba54-db90-6b56-23e006eb1dbe@linux.intel.com> Date: Wed, 16 Jun 2021 11:23:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development , Banajit Goswami , Stephan Gerhold , linux-arm-msm , Patrick Lai , Mark Brown , Bjorn Andersson , Liam Girdwood , Tzung-Bi Shih , Takashi Iwai , Tzung-Bi Shih , Rob Herring , Rohit kumar , Andy Gross , Douglas Anderson , Dylan Reid , Stephen Boyd , Judy Hsiao , "moderated list:ARM/Mediatek SoC support" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> I don't think it's correct to declare 4-channel support at the >> individual codec DAI level when in practice each device will be provided >> with a TDM mask that selects two slots. > > On this platform there is no TDM support, so there were two I2S data lines. > >> >> This is confusing device capabilities and TDM link configuration. > > I see that in most of the use cases of multiple amps, we should use > codecs and num_codecs of the link. > But in this case we only want one codec to control the only GPIO > shared by 4 max98357a amps > I think we should be able to use 1 max98357 codec and 3 dummy codec to > fulfill this use case. > Not sure if the number of dummy codec would really matter. > With num_codec > 1 we should be able to bypass the channel checking > and just use the channel from CPU DAI. Interesting, I haven't seen such 'multi-lane' solutions so far for I2S.