From: <Claudiu.Beznea@microchip.com>
To: <walker.chen@starfivetech.com>, <broonie@kernel.org>,
<lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<Conor.Dooley@microchip.com>,
<emil.renner.berthing@canonical.com>, <hal.feng@starfivetech.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v5 2/3] ASoC: starfive: Add JH7110 TDM driver
Date: Tue, 30 May 2023 07:06:04 +0000 [thread overview]
Message-ID: <7a1a3ac3-10ec-9935-bca1-023cec6c0024@microchip.com> (raw)
In-Reply-To: <143e2fa2-e85d-8036-4f74-ca250c026c1b@microchip.com>
On 30.05.2023 09:47, Claudiu Beznea - M18063 wrote:
>> + #define CLKPOL_BIT 5
>> + #define TRITXEN_BIT 4
>> + #define ELM_BIT 3
>> + #define SYNCM_BIT 2
>> + #define MS_BIT 1
> Instead of these *_BIT defines as plain numbers you can defined them using
> BIT() macro and use macros in place instead of
> enum TDM_CLKPOL clkpolity;
> enum TDM_ELM elm;
> enum TDM_SYNCM syncm;
> enum TDM_MASTER_SLAVE_MODE ms_mode;
Something happens w/ my email client and I sent this section by accident.
Thus you can ignore it.
next prev parent reply other threads:[~2023-05-30 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 14:53 [PATCH v5 0/3] Add TDM audio on StarFive JH7110 Walker Chen
2023-05-26 14:54 ` [PATCH v5 1/3] ASoC: dt-bindings: Add TDM controller bindings for " Walker Chen
2023-05-26 14:54 ` [PATCH v5 2/3] ASoC: starfive: Add JH7110 TDM driver Walker Chen
2023-05-30 6:47 ` Claudiu.Beznea
2023-05-30 7:06 ` Claudiu.Beznea [this message]
2023-05-30 7:31 ` Walker Chen
2023-05-26 14:54 ` [PATCH v5 3/3] riscv: dts: starfive: add the node and pins configuration for tdm Walker Chen
2023-05-31 6:23 ` Hal Feng
2023-05-31 6:30 ` Walker Chen
2023-05-31 6:42 ` Hal Feng
2023-06-01 15:44 ` (subset) [PATCH v5 0/3] Add TDM audio on StarFive JH7110 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a1a3ac3-10ec-9935-bca1-023cec6c0024@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=hal.feng@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox