Re: [PATCH 1/2] Revert "ASoC: amd: acp: Set gpio_spkr_en to None for max speaker amplifer in machine driver"

["Reddy, V sujith kumar" <vsujithkumar.reddy@amd.com>]

On 5/12/22 23:36, Mark Brown wrote:
> On Thu, May 12, 2022 at 09:10:22PM +0530, V sujith kumar Reddy wrote:
>> RT1019 codec has two ways of controlling the en_spkr.
>> one way is controlling through gpio pin method the another way is through codec register update.
>>
>> Now Speaker enable/disable is controlled  through register update in BIOS.
>> So this patch reverse gpio logic, which is no longer in use.
> Surely this needs to be keyed off BIOS version otherwise we'll break
> things for systems where the user hasn't updated their BIOS?
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.


Hi Mark,

There is a mistake in commit message,Speaker enable and disable is 
controlled through rt1019 codec driver not through Bios.

Apologies for the inconvenience. We will update the commit message and 
resend.