From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7565CCDB483 for ; Thu, 19 Oct 2023 14:23:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 27AA89F6; Thu, 19 Oct 2023 16:23:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 27AA89F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697725435; bh=Wt+aX4la4eXjHv+2TrkEeyyK7itYRmgyqM39uYkX+0o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ArYzg3EVcWbhK9cjdfDdejrnboYsqHJOd2d1xJRgE+FxwI84Oi8jSE2CIleYP9Cvx 6t2RsEzRCghSMUjvCYqeybh/t2qpeONBNB65vm5mgS3O3ur+XE7kAb6vSu+VjY+oCY czxOtdxFXvY8FsIWjQ3WRWYtS+Amg+4OSoeFRxHg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9945FF8025F; Thu, 19 Oct 2023 16:22:35 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3472CF8025F; Thu, 19 Oct 2023 16:22:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1ACD6F8025F; Thu, 19 Oct 2023 16:22:31 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03E30F800C9 for ; Thu, 19 Oct 2023 16:22:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03E30F800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=A8H9gWoD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697725349; x=1729261349; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Wt+aX4la4eXjHv+2TrkEeyyK7itYRmgyqM39uYkX+0o=; b=A8H9gWoDw9uvK0uw0e/VKJOao33b+2AyFRcrnDKkVkg6T5+Qafm7inSP rL8FmQ8l/V03zyviUqKfhdKJP7CbEtPVQpFSTDl3SpnhHg9zxTf9l1Y83 fCgrzWnbn9dY1B0FCStijyz6py3rFBVqSpS+RbVvaPvlLfJS+/quxNszM XXpL1ufNTrHMMagMJZiAEfVZlZe1Viu77c8ieTIbIoMFkg+gXBZ8okNU/ vdQACPzAHPwuvTb9ifdn/rmdxt0cIZQeskq0B7QNq7PzsV176LStvl3Un lSBeMFpH9R2p84C6eMIb6eoiCA63LTReY6B623D1Uk1cB9u4qeps6rYR0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="385136633" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="385136633" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 07:22:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="786402701" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="786402701" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.94.0.91]) ([10.94.0.91]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 07:22:22 -0700 Message-ID: <7b08520e-8f36-45a1-9b7a-316a33c8e8c4@linux.intel.com> Date: Thu, 19 Oct 2023 16:22:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] ALSA: hda: intel-dsp-config: Fix JSL Chromebook quirk detection To: Mark Hasemeyer , LKML Cc: Dmitry Torokhov , Guenter Roeck , stable@vger.kernel.org, Andy Shevchenko , Bard Liao , Brady Norander , Jaroslav Kysela , Mark Brown , Pierre-Louis Bossart , Takashi Iwai , alsa-devel@alsa-project.org References: <20231018235944.1860717-1-markhas@chromium.org> Content-Language: en-US From: =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= In-Reply-To: <20231018235944.1860717-1-markhas@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 6RM7KCOFETLZ32VOZEYPTHWVYN2UCMUY X-Message-ID-Hash: 6RM7KCOFETLZ32VOZEYPTHWVYN2UCMUY X-MailFrom: amadeuszx.slawinski@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/19/2023 1:59 AM, Mark Hasemeyer wrote: > Some Jasperlake Chromebooks overwrite the system vendor DMI value to the > name of the OEM that manufactured the device. This breaks Chromebook > quirk detection as it expects the system vendor to be "Google". > > Add another quirk detection entry that looks for "Google" in the BIOS > version. > > Cc: stable@vger.kernel.org > Signed-off-by: Mark Hasemeyer > --- > > sound/hda/intel-dsp-config.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c > index 24a948baf1bc..756fa0aa69bb 100644 > --- a/sound/hda/intel-dsp-config.c > +++ b/sound/hda/intel-dsp-config.c > @@ -336,6 +336,12 @@ static const struct config_entry config_table[] = { > DMI_MATCH(DMI_SYS_VENDOR, "Google"), > } > }, > + { > + .ident = "Google firmware", > + .matches = { > + DMI_MATCH(DMI_BIOS_VERSION, "Google"), > + } > + }, > {} > } > }, I would assume that platform that has DMI_SYS_VENDOR set to "Google", also has DMI_BIOS_VERSION set to "Google", so perhaps just replace DMI_SYS_VENDOR match with DMI_BIOS_VERSION, to keep table small? Or is that not a case?