From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237D8C433E0 for ; Mon, 6 Jul 2020 15:04:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A342E206E6 for ; Mon, 6 Jul 2020 15:04:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="nxeYOw3h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A342E206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 40B181615; Mon, 6 Jul 2020 17:03:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 40B181615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594047861; bh=N3mjiEdu6UpxcD7uc35235j2jeVGa1VI1eAyhWT6Uwk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nxeYOw3hu++nLk4UzfM8OqGLaDQV2/TlLOhj8r0J+55wtwdPH7bBzsYPgYjFCwbqI sVzV/8J1eKIGm6AxhFUC01Z5e8EgMuPunQU/qY/MirDOAFD6MOz4Fy/+sYuwVKYLhH MemJK8LZOGkIjIWV2uxvC0yqMGbuiBHgg/+J84pM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CAED5F80150; Mon, 6 Jul 2020 17:03:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1875DF8015A; Mon, 6 Jul 2020 17:03:28 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61E24F80125 for ; Mon, 6 Jul 2020 17:03:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61E24F80125 IronPort-SDR: jvgMVA3pVbjhVtV1CNKlWaPk7qPCEgMqRltTCUXbSyNNz1679LmMX+XhAH3uMizdckJSyTFgqp +w0QV57425Cw== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="147434763" X-IronPort-AV: E=Sophos;i="5.75,320,1589266800"; d="scan'208";a="147434763" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 08:03:16 -0700 IronPort-SDR: L2Z3VR5sFl9G4jx008pgy5I4rdrzbvcEZVVZuOT1zJtYIDuouKToK++PVl7NF1i3/4++i90Gb7 TBDYFAOfGVFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,320,1589266800"; d="scan'208";a="313986367" Received: from aislam-mobl1.amr.corp.intel.com ([10.212.167.133]) by orsmga008.jf.intel.com with ESMTP; 06 Jul 2020 08:03:15 -0700 Subject: Re: [PATCH 3/8] ASoC: samsung: pcm: fix kernel-doc To: Sylwester Nawrocki , alsa-devel@alsa-project.org References: <20200702165901.164100-1-pierre-louis.bossart@linux.intel.com> <20200702165901.164100-4-pierre-louis.bossart@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <7b485413-98f1-fb13-2e82-4eeacbfff6dc@linux.intel.com> Date: Mon, 6 Jul 2020 10:03:14 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: tiwai@suse.de, open list , Takashi Iwai , Liam Girdwood , Krzysztof Kozlowski , Sangbeom Kim , broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/3/20 1:47 PM, Sylwester Nawrocki wrote: > On 02.07.2020 18:58, Pierre-Louis Bossart wrote: >> Fix W=1 warnings - missing fields in structure >> >> Signed-off-by: Pierre-Louis Bossart >> --- >> sound/soc/samsung/pcm.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c >> index a5b1a12b3496..86eefbc89e9e 100644 >> --- a/sound/soc/samsung/pcm.c >> +++ b/sound/soc/samsung/pcm.c >> @@ -104,8 +104,13 @@ > > Thank you for the patch, I have some suggestions to improve the comments. > >> /** >> * struct s3c_pcm_info - S3C PCM Controller information >> + * @lock: Spin lock > > @lock: Spin lock to serialize access to the device registers and @idle_clk > >> * @dev: The parent device passed to use from the probe. >> * @regs: The pointer to the device register block. >> + * @sclk_per_fs: number of sclk per frame sync >> + * @idleclk: Whether to keep PCMSCLK enabled even when idle(no active xfer) > > How about adding space before the opening parenthesis? > >> + * @pclk: the pclk pointer > > @pclk: the PCLK_PCM (pcm) clock pointer > >> + * @cclk: the clck pointer > > @cclk: the SCLK_AUDIO (audio-bus) clock pointer > >> * @dma_playback: DMA information for playback channel. >> * @dma_capture: DMA information for capture channel. >> */ > > With above changes feel free to add: > Reviewed-by: Sylwester Nawrocki I wasn't really happy with the lame comments I added for pclk and cclk, thanks for suggesting a better wording. Will fix in a v2.