From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AB23C38142 for ; Wed, 1 Feb 2023 03:53:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E975E1EB; Wed, 1 Feb 2023 04:52:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E975E1EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675223603; bh=rmCcr90OIBPdiIGNAQ9gadT4jTI03VlYZhtAK3NArTU=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VDhsVNbBfkMWkSAZtJ+Sf9LNAjM9K/8txBwkAx3iljoOgV6uvjTA701L0R0Z4wp0x Zoyly6lxZunZUYiVpLYqqvIdebZJoF40M3YcsH1YEFkABuv0rugNV+PbdUHWOvRqCs +RwoJO9Ww4BLOBP5RqsD+qQvOTs8KhDiV7BreBhA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A8D5F80155; Wed, 1 Feb 2023 04:52:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4483AF80423; Wed, 1 Feb 2023 04:52:28 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4E464F80246 for ; Wed, 1 Feb 2023 04:52:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4E464F80246 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=TvIuKIk3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675223542; x=1706759542; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=rmCcr90OIBPdiIGNAQ9gadT4jTI03VlYZhtAK3NArTU=; b=TvIuKIk3/LGy6/4ilBfEpQ5dPx1b8S45j1wa4LEXY2LKrE1K1uIo6KuC u6fvf5czzvoQVFctlXNDQOlqMIvjUUpURoz0a0bvHqf18cGhoT0JL2MJW +ub9sur9nm9H9XLvxbroxYdE+56mWxstBxEWsf4nhCWucwszcoAJus0SC VtcW9w+H+j3vrlSXfedaKTJe/o0XRgEEQjkmmY3DMKOQ5eU2PKSehLc+4 Q3D5ngzdriXvfmual/CWZKgDTwV3VFtPfgsqoZfSGjfc9PuiBFd0OibH4 csB3SwDPz1ht1UZnTndXY3+3cvqnJwWKx774ko45sSPnUufsAoAewJo+N w==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="414238354" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="414238354" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 19:52:17 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="788686482" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="788686482" Received: from ncollins-mobl.amr.corp.intel.com (HELO [10.212.85.244]) ([10.212.85.244]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 19:52:15 -0800 Message-ID: <7b8fe2b6-84cb-e8c8-22aa-2d940a5c68b7@linux.intel.com> Date: Tue, 31 Jan 2023 21:52:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH 01/19] ASoC: amd: ps: create platform devices based on acp config To: "Mukunda,Vijendar" , "Limonciello, Mario" , "broonie@kernel.org" , "vkoul@kernel.org" , "alsa-devel@alsa-project.org" References: <20230111090222.2016499-1-Vijendar.Mukunda@amd.com> <20230111090222.2016499-2-Vijendar.Mukunda@amd.com> <9f2229fb-499b-f802-993b-56a7ad2ce361@linux.intel.com> <257b6f1e-f403-573f-3978-13ffb14342ad@amd.com> <2b4c12ce-2586-0277-ede0-560f8317e4e4@linux.intel.com> <27eabbf2-eff2-0964-b72b-f9db251c3b57@amd.com> <87ddd91b-fb5f-4f27-942b-dc439b32ce20@amd.com> <2ea354bc-4263-1db6-4423-4de1b0d4e535@amd.com> <815ab487-a1a3-1978-94fc-b60e931c2848@linux.intel.com> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Katragadda, Mastan" , "Dommati, Sunil-kumar" , "Hiregoudar, Basavaraj" , Takashi Iwai , Liam Girdwood , open list , Nathan Chancellor , "Saba Kareem, Syed" , "kondaveeti, Arungopal" , Sanyog Kale , Bard Liao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> In above case, two manager instances will be created. >>> When manager under SWC1 scope tries to add peripheral >>> device, In sdw_slave_add() API its failing because peripheral >>> device descriptor uses link id followed by 48bit encoded address. >>> In above scenarios, both the manager's link id is zero only. >> what fails exactly? The device_register() ? >> >> If yes, what the issue. the device name? > device_register() is failing because of duplication of > device name. >> I wonder if we need to use something like >> >> "name shall be sdw:bus_id:link:mfg:part:class" >> >> so as to uniquify the device name, if that was the problem. > Yes correct. can you check https://github.com/thesofproject/linux/pull/4165 and see if this works for you? I tested it on Intel platforms.