From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, Oder Chiou <oder_chiou@realtek.com>,
alsa-devel@alsa-project.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH 2/3] ASoC: rt5682: fix compilation issues without I2C
Date: Tue, 10 Mar 2020 13:50:02 -0500 [thread overview]
Message-ID: <7bd53344-7bda-e2b3-a819-c05caff15d71@linux.intel.com> (raw)
In-Reply-To: <20200310171929.GM4106@sirena.org.uk>
On 3/10/20 12:19 PM, Mark Brown wrote:
> On Tue, Mar 10, 2020 at 11:35:08AM -0500, Pierre-Louis Bossart wrote:
>> Exclude all I2C-related code from compilation to avoid compilation
>> errors and defined but not used warnings.
>
> I think it would be better to do this by factoring the bus code out into
> a separate file like we've done with I2C and SPI, it's neater than
> ifdefs and easier to get right going forwards.
Agree, this was just a quick fix to solve compilation issues.
next prev parent reply other threads:[~2020-03-10 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 16:35 [PATCH 0/3] ASoC: rt5682: fix Kconfig/compilation issues when I2C is not selected Pierre-Louis Bossart
2020-03-10 16:35 ` [PATCH 1/3] ASoC: rt5682: fix unmet dependencies Pierre-Louis Bossart
2020-03-10 18:19 ` Applied "ASoC: rt5682: fix unmet dependencies" to the asoc tree Mark Brown
2020-03-10 16:35 ` [PATCH 2/3] ASoC: rt5682: fix compilation issues without I2C Pierre-Louis Bossart
2020-03-10 17:19 ` Mark Brown
2020-03-10 18:50 ` Pierre-Louis Bossart [this message]
2020-03-10 16:35 ` [PATCH 3/3] ASoC: rt5682-sdw: fix 'defined but not used' pm functions Pierre-Louis Bossart
2020-03-10 18:19 ` Applied "ASoC: rt5682-sdw: fix 'defined but not used' pm functions" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd53344-7bda-e2b3-a819-c05caff15d71@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lkp@intel.com \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox