From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F129C433E0 for ; Thu, 2 Jul 2020 19:04:32 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C3DF20702 for ; Thu, 2 Jul 2020 19:04:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="K72nmRWo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C3DF20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DB2F516BF; Thu, 2 Jul 2020 21:03:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DB2F516BF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593716669; bh=8hdEW7EwqIN/1VG2iLcQDuqIN5qDb+WvsjNtxbPCL7Y=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K72nmRWoB07cEifNzTvYvN6jxiOZloxLkugjDrS84ORl7ux5T7WfTdqGWTb5kT05L BcDb6JsAqmzEt7DCMJqGz6rcPxAmUwtTXqPZ6/kWu8tj5zhjvGr1Ver4ppGhEcEbAA 7aRmVXfXSBkpkE5dmTqXlSd/OWKoMURI+93PxnYk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 65E33F80134; Thu, 2 Jul 2020 21:03:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7C590F8022D; Thu, 2 Jul 2020 21:03:37 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7A1C5F80134 for ; Thu, 2 Jul 2020 21:03:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7A1C5F80134 IronPort-SDR: CIsuDbZe40thPOVbcOldV+4yqv5ogy2bPd/T5w20YVbCXepD6fc6v7SelqmR9cCRagoHgEgNG/ ElYQrDZNP87A== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="146088766" X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="146088766" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:03:23 -0700 IronPort-SDR: ITwhDjjC2EW5TkDGnDY5YhDJPnao/dKwEHsS0zhlA07dwxJxe7RUuCj3idyidbNsnHlTLiFRvr Qic3MYf842Mg== X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="295989015" Received: from dhprice-mobl1.amr.corp.intel.com (HELO [10.254.75.219]) ([10.254.75.219]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 12:03:22 -0700 Subject: Re: [PATCH 3/6] ASoC: fsl: fsl-asoc-card: fix kernel-doc To: Nicolin Chen References: <20200702172227.164474-1-pierre-louis.bossart@linux.intel.com> <20200702172227.164474-4-pierre-louis.bossart@linux.intel.com> <20200702184727.GD23935@Asurada-Nvidia> From: Pierre-Louis Bossart Message-ID: <7c6fac59-562c-d3b5-8eea-3e0f450cee6b@linux.intel.com> Date: Thu, 2 Jul 2020 14:03:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702184727.GD23935@Asurada-Nvidia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , tiwai@suse.de, "open list:FREESCALE SOC SOUND DRIVERS" , Takashi Iwai , Liam Girdwood , broonie@kernel.org, Fabio Estevam , open list X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 7/2/20 1:47 PM, Nicolin Chen wrote: > On Thu, Jul 02, 2020 at 12:22:24PM -0500, Pierre-Louis Bossart wrote: >> Fix W=1 warnings. Kernel-doc syntax was not properly used. >> >> Signed-off-by: Pierre-Louis Bossart >> --- >> sound/soc/fsl/fsl-asoc-card.c | 21 +++++++++------------ >> 1 file changed, 9 insertions(+), 12 deletions(-) >> >> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c > >> /** >> - * Freescale Generic ASOC card private data >> + * struct fsl_asoc_card_priv - struct Freescale Generic ASOC card private data > > Just a nit, can you drop the "struct" before "Freescale"? > Other parts of your changes don't really add this word. will do, thanks for spotting this. > Otherwise, > Acked-by: Nicolin Chen >