From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Matt Ranostay <matt@ranostay.consulting>,
Tony Lindgren <tony@atomide.com>
Cc: alsa-devel@alsa-project.org,
Linux OMAP List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v5] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches
Date: Tue, 10 Jan 2017 09:38:18 +0200 [thread overview]
Message-ID: <7ca677ec-e79d-2418-5435-3cbecb1da3e0@ti.com> (raw)
In-Reply-To: <CAJ_EiSR3aZQztVKhQsnmVQUAgdDo0mtBZZ1=9LrHGOimGr-qaA@mail.gmail.com>
On 01/10/2017 05:23 AM, Matt Ranostay wrote:
> Yeah I can reproduce the issue you are mentioning. Anyone have a
> suggestion how on to resolve? Guessing the QoS function calls need to
> be in an atomic context and the omap_mcbsp_* functions can sleep
I think it is the other way around: we call a sleeping function from
atomic context. pcm_trigger is atomic.
Most probably we should add the .prepare callback to mcbsp_dai_ops and
do the QoS update which is done in omap_mcbsp_start() there. The things
we do in omap_mcbsp_stop() then can be moved to omap_mcbsp_dai_shutdown().
I think the code would handle cases when user space stops the stream,
re-configures it and starts it with different parameters w/o closing it.
--
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-01-10 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 1:59 [PATCH v5] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches Matt Ranostay
2017-01-09 13:12 ` Peter Ujfalusi
2017-01-09 19:21 ` Tony Lindgren
2017-01-09 21:46 ` Matt Ranostay
2017-01-09 21:56 ` Tony Lindgren
2017-01-09 22:11 ` Matt Ranostay
2017-01-09 23:56 ` Tony Lindgren
2017-01-10 3:23 ` Matt Ranostay
2017-01-10 7:38 ` Peter Ujfalusi [this message]
2017-01-10 17:27 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca677ec-e79d-2418-5435-3cbecb1da3e0@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox