From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Kenneth Westfield <kwestfie@codeaurora.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage
Date: Fri, 28 Oct 2016 22:11:35 +0100 [thread overview]
Message-ID: <7de5b48a-c3e4-0111-b21d-4d733786b5d9@linaro.org> (raw)
In-Reply-To: <20161028182644.nbsbm6h7fcj3rlcj@sirena.org.uk>
On 28/10/16 19:26, Mark Brown wrote:
> On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote:
>> This patch fixes lpass-platform driver which was broken in v4.9-rc1.
>> lpass_pcm_data data structure holds information specific to stream.
>> Holding a single private pointer to it in global lpass_data
>> will not work, because it would be overwritten by for each pcm instance.
>
> This is a bug fix but you've made it depend on patch 1 which is just a
> refactoring and should therefore not be sent to Linus as a fix. Please
> don't do this, fix bugs first then do any cleanups and new
> functionality. That way we can send fixes to Linus without needing to
> pull in extra stuff.
Sorry about that, I will resend the fix patch without any dependencies.
Thanks,
srini
>
next prev parent reply other threads:[~2016-10-28 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 15:32 [PATCH 0/3] ASoC: lpass-platform: Fixes and Cleanup Srinivas Kandagatla
2016-10-28 15:32 ` [PATCH 1/3] ASoC: lpass-platform: use dma_ch instead of rdma_ch/wrdma_ch Srinivas Kandagatla
2016-10-29 16:12 ` Kenneth Westfield
2016-10-28 15:32 ` [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage Srinivas Kandagatla
2016-10-28 18:26 ` Mark Brown
2016-10-28 21:11 ` Srinivas Kandagatla [this message]
2016-10-29 16:14 ` Kenneth Westfield
2016-10-28 15:32 ` [PATCH 3/3] ASoC: lpass-cpu: add module licence and description Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de5b48a-c3e4-0111-b21d-4d733786b5d9@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=kwestfie@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).