[ALSA - driver 0000640]: azx code is nasty

[bugtrack@alsa-project.org]

The following issue has been CLOSED
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=640> 
======================================================================
Reported By:                russell
Assigned To:                
======================================================================
Project:                    ALSA - driver
Issue ID:                   640
Category:                   PCI - azx
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     closed
Distribution:               Debian/Ubuntu
Kernel Version:             2.6.8.1
Resolution:                 fixed
Fixed in Version:           
======================================================================
Date Submitted:             11-10-2004 14:30 CET
Last Modified:              01-11-2005 16:53 CET
======================================================================
Summary:                    azx code is nasty
Description: 
Some of the code in the azx driver is very difficult to read, depending on
how you set up tabs etc in your IDE. This is a[n almost] purely cosmetic
change to codec_enum.c

I have commented out some of the snd_printdd()s inside the smaller helper
functions too (to make my poor l'il log look nicer). I have also changed
one obviously inefficient function (get_bit_value()) into a macro. All
seems to compile and work about as well as 1.0.7rc2 does (for me, not
particularly well - hence my work on it)
======================================================================

----------------------------------------------------------------------
 russell - 11-12-04 15:40 
----------------------------------------------------------------------
My apologies, I was not aware of that document. Should be more fixed now.

The one glaring area where it isn't is line length. At times, there are
indents up to 7 levels deep, leaving less than 30 characters for code - it
would be impractical to try to wrap some of this code. This is more of an
architectural issue with the code than simply a style issue (and it is
easy to teach most editors to render a tab as two characters wide, which
largely alleviates the problem). This is something which I hope to address
fairly soon.

----------------------------------------------------------------------
 tiwai - 12-08-04 19:54 
----------------------------------------------------------------------
The code is now completely written.  Thanks.

Issue History
Date Modified  Username       Field                    Change              
======================================================================
11-10-04 14:30 russell        New Issue                                    
11-10-04 14:30 russell        File Added: codec_enum.c                     
11-10-04 14:30 russell        Distribution              => Debian/Ubuntu   
11-10-04 14:30 russell        Kernel Version            => 2.6.8.1         
11-12-04 12:22 tiwai          Note Added: 0002393                          
11-12-04 15:40 russell        Note Added: 0002398                          
11-12-04 15:40 russell        File Added: codec_enum.c                     
12-08-04 19:54 tiwai          Status                   new => resolved     
12-08-04 19:54 tiwai          Resolution               open => fixed       
12-08-04 19:54 tiwai          Assigned To               => tiwai           
12-08-04 19:54 tiwai          Note Added: 0002792                          
12-08-04 19:54 tiwai          Assigned To              tiwai =>            
01-11-05 16:53 tiwai          Status                   resolved => closed  
======================================================================




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt