From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B87DC00A98 for ; Fri, 20 Oct 2023 17:01:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6C3B884A; Fri, 20 Oct 2023 19:00:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6C3B884A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1697821294; bh=DFuYk/iZFo38XXz5QEJHG+rb8/gZLVBaR1l70X7qLgQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FeUUfk+Kl/wR0LtpHKw/ofgpjs0IXnAFsZGmu8sYJYvOEMeGE1M7xWTP3lM5RVy7Y xjbtYHV2HDOf0hICTAzrInK6r1RUB9mM7hvwMBnmTRTWHl+DkkElARusb9pHV72kPc ngjVY+qYip8RIplPfjqCGZJQsjM6Y7ZfQGFwM9ug= Received: by alsa1.perex.cz (Postfix, from userid 50401) id CB5E7F8027B; Fri, 20 Oct 2023 19:00:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2A861F8025F; Fri, 20 Oct 2023 19:00:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 84D67F8025F; Fri, 20 Oct 2023 19:00:09 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42AF2F800C9 for ; Fri, 20 Oct 2023 19:00:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42AF2F800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=lqLUN1XY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697821203; x=1729357203; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DFuYk/iZFo38XXz5QEJHG+rb8/gZLVBaR1l70X7qLgQ=; b=lqLUN1XY//OLyLF4Jr0+BeqW+jJVkKutThSzGnJ1hK5Hy6/CDqVhvvAx z59fwE/To8Kl0x2pzeAtMcUzPvyukGBpYFPhIkpSezxrY1NPpULbRtj/P AyC+E+/zDDwtfdNbm2w5yVyze/GumoYEYFWA5F7I1QWOk3BjI2+tCGSxZ CJOnP2kEWfO6quYmhfy8+xD1n+g7QUcwzTJ1SBjyqbHlL8iNvg976dYRV UYGE3yFj4/KLiC1mneiZ/DIvie79W7h01JI+syVw79KpZzhfnzhw7FWTI uFaXWcMCmMPIjjsogE9Lzq+dZ4xpztiCRnvUvUgPJqZ0ikd/OR0Dq4Xv0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="5144941" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="5144941" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 09:59:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="901189445" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="901189445" Received: from mtadesse-mobl.amr.corp.intel.com (HELO [10.209.140.77]) ([10.209.140.77]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 09:57:46 -0700 Message-ID: <80f8a742-4a60-4c75-9093-dcd63de70b66@linux.intel.com> Date: Fri, 20 Oct 2023 11:59:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] ALSA: hda: intel-dsp-config: Fix JSL Chromebook quirk detection Content-Language: en-US To: Mark Hasemeyer Cc: =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= , LKML , Dmitry Torokhov , Guenter Roeck , stable@vger.kernel.org, Andy Shevchenko , Bard Liao , Brady Norander , Jaroslav Kysela , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, Curtis Malainey References: <20231018235944.1860717-1-markhas@chromium.org> <7b08520e-8f36-45a1-9b7a-316a33c8e8c4@linux.intel.com> <5bc82aca-04f2-463b-ba52-34bcae6724d5@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: EPG4CM4FD7TKLXZZ5PXCDQXJZRYLIBHK X-Message-ID-Hash: EPG4CM4FD7TKLXZZ5PXCDQXJZRYLIBHK X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/20/23 10:36, Mark Hasemeyer wrote: >> FWIW we use this other quirk: >> DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), > > Unfortunately DMI_PRODUCT_FAMILY is empty on these particular devices. > The coreboot version field is the only entry that has "Google" in it. well then you have additional issues with the DMI quirk for the firmware selection in sound/soc/sof/sof-pci-dev.c, { .ident = "Google Chromebooks", .callback = chromebook_use_community_key, .matches = { DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), } }, which means you need additional kernel parameters to provide the location of the firmware.... >> How many engineers does it take to identify a Chromebook, eh? > > Ha! There has been some discussion about this: to come up with a > canonical way for Chromebook identification throughout the kernel. But > nothing has been settled on AFAIK. There's been multiple rounds of discussions with Curtis, we introduced DMI_OEM_STRING but it's still not good enough, and now the previous conventions are not being followed on what is a relatively old platform already...