From: Robin Murphy <robin.murphy@arm.com>
To: Coiby Xu <coiby.xu@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Heiko Stuebner <heiko@sntech.de>,
open list <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
Mark Brown <broonie@kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/25] ASoC: rockchip: remove unnecessary CONFIG_PM_SLEEP
Date: Thu, 29 Oct 2020 10:33:52 +0000 [thread overview]
Message-ID: <8589f68f-fa6b-d75e-d7be-fbb354adbde0@arm.com> (raw)
In-Reply-To: <20201029074301.226644-4-coiby.xu@gmail.com>
On 2020-10-29 07:42, Coiby Xu wrote:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
I don't see anything in the !CONFIG_PM_CONFIG side of
SET_SYSTEM_SLEEP_PM_OPS() that prevents unused function warnings for the
callbacks - does this change depend on some other patch or is it just wrong?
Robin.
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
> sound/soc/rockchip/rockchip_pdm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c
> index 5adb293d0435..f3c19310aeeb 100644
> --- a/sound/soc/rockchip/rockchip_pdm.c
> +++ b/sound/soc/rockchip/rockchip_pdm.c
> @@ -574,7 +574,6 @@ static int rockchip_pdm_remove(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int rockchip_pdm_suspend(struct device *dev)
> {
> struct rk_pdm_dev *pdm = dev_get_drvdata(dev);
> @@ -601,7 +600,6 @@ static int rockchip_pdm_resume(struct device *dev)
>
> return ret;
> }
> -#endif
>
> static const struct dev_pm_ops rockchip_pdm_pm_ops = {
> SET_RUNTIME_PM_OPS(rockchip_pdm_runtime_suspend,
>
next prev parent reply other threads:[~2020-10-29 10:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 7:42 [PATCH 01/25] ALSA: core: pcm: remove unnecessary CONFIG_PM_SLEEP Coiby Xu
2020-10-29 7:42 ` [PATCH 02/25] ASoC: fsl: fsl_ssi: " Coiby Xu
2020-10-29 7:42 ` [PATCH 03/25] ASoC: fsl: " Coiby Xu
2020-10-29 7:42 ` [PATCH 04/25] ASoC: rockchip: " Coiby Xu
2020-10-29 10:33 ` Robin Murphy [this message]
2020-10-29 14:23 ` Coiby Xu
2020-10-29 7:42 ` [PATCH 05/25] ASoC: img: " Coiby Xu
2020-10-29 7:42 ` [PATCH 06/25] ASoC: img-spdif-in: " Coiby Xu
2020-10-29 7:42 ` [PATCH 07/25] ASoC: img-spdif-out: " Coiby Xu
2020-10-29 7:42 ` [PATCH 08/25] ASoC: img-i2s-out: " Coiby Xu
2020-10-29 7:42 ` [PATCH 09/25] ASoC: tegra: " Coiby Xu
2020-10-29 7:42 ` [PATCH 10/25] " Coiby Xu
2020-10-29 7:42 ` [PATCH 11/25] ASoC: hdac: " Coiby Xu
2020-10-29 7:42 ` [PATCH 12/25] ASoC: stm32: sai: " Coiby Xu
2020-10-29 7:42 ` [PATCH 13/25] ASoC: stm32: spdifrx: " Coiby Xu
2020-10-29 7:42 ` [PATCH 14/25] ASoC: stm32: i2s: " Coiby Xu
2020-10-29 7:42 ` [PATCH 15/25] ASoC: stm32: sai: " Coiby Xu
2020-10-29 7:42 ` [PATCH 16/25] ASoC: sirf: " Coiby Xu
2020-10-29 7:42 ` [PATCH 17/25] ASoC: hdac_hdmi: " Coiby Xu
2020-10-29 7:42 ` [PATCH 18/25] ASoC: codecs: max98373: " Coiby Xu
2020-10-29 7:42 ` [PATCH 19/25] ASoC: sirf-audio: " Coiby Xu
2020-10-29 7:42 ` [PATCH 20/25] ASoC: max98390: " Coiby Xu
2020-10-29 7:42 ` [PATCH 21/25] ASoC: codecs: max98090: " Coiby Xu
2020-10-29 7:42 ` [PATCH 22/25] ASoC: max98927: " Coiby Xu
2020-10-29 7:42 ` [PATCH 23/25] ASoC: ts3a227e: " Coiby Xu
2020-10-29 7:43 ` [PATCH 24/25] ASoC: wm8994: " Coiby Xu
2020-10-29 15:55 ` Charles Keepax
2020-10-29 7:43 ` [PATCH 25/25] ALSA: aoa: " Coiby Xu
2020-10-29 7:48 ` [PATCH 01/25] ALSA: core: pcm: " Takashi Iwai
2020-10-29 14:37 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8589f68f-fa6b-d75e-d7be-fbb354adbde0@arm.com \
--to=robin.murphy@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=coiby.xu@gmail.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).