From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15AFC2D0A3 for ; Thu, 29 Oct 2020 10:34:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA99120791 for ; Thu, 29 Oct 2020 10:34:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="F8aHPMq9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA99120791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 34342112; Thu, 29 Oct 2020 11:34:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 34342112 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603967695; bh=k/984BgyhB1Upv0lR7Ig9+gDbBKUq1H89YLUyevXRDQ=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=F8aHPMq9nRu6sis20nQvoLy5xp7m1InNOSDNLdinOxdiz9Yz3VClFShXVn2c/GesO pP46F0gFe7mr+i4oc3h/ZXbsACZGrIAnButBF0h8Ou7/zQ+3jiztXzbNitGDwIYPEP e8d6M2w79mIi+4g5CjKRoaArgUWY2r2yXixs4ilc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9BDBFF801D8; Thu, 29 Oct 2020 11:34:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A0862F8020D; Thu, 29 Oct 2020 11:34:02 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 1EF8DF800D8 for ; Thu, 29 Oct 2020 11:33:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1EF8DF800D8 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4080C139F; Thu, 29 Oct 2020 03:33:55 -0700 (PDT) Received: from [10.57.54.223] (unknown [10.57.54.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C00453F66E; Thu, 29 Oct 2020 03:33:53 -0700 (PDT) Subject: Re: [PATCH 04/25] ASoC: rockchip: remove unnecessary CONFIG_PM_SLEEP To: Coiby Xu , Jaroslav Kysela , Takashi Iwai References: <20201029074301.226644-1-coiby.xu@gmail.com> <20201029074301.226644-4-coiby.xu@gmail.com> From: Robin Murphy Message-ID: <8589f68f-fa6b-d75e-d7be-fbb354adbde0@arm.com> Date: Thu, 29 Oct 2020 10:33:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201029074301.226644-4-coiby.xu@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Heiko Stuebner , open list , Liam Girdwood , "open list:ARM/Rockchip SoC support" , Mark Brown , "moderated list:ARM/Rockchip SoC support" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-10-29 07:42, Coiby Xu wrote: > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. I don't see anything in the !CONFIG_PM_CONFIG side of SET_SYSTEM_SLEEP_PM_OPS() that prevents unused function warnings for the callbacks - does this change depend on some other patch or is it just wrong? Robin. > Signed-off-by: Coiby Xu > --- > sound/soc/rockchip/rockchip_pdm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c > index 5adb293d0435..f3c19310aeeb 100644 > --- a/sound/soc/rockchip/rockchip_pdm.c > +++ b/sound/soc/rockchip/rockchip_pdm.c > @@ -574,7 +574,6 @@ static int rockchip_pdm_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int rockchip_pdm_suspend(struct device *dev) > { > struct rk_pdm_dev *pdm = dev_get_drvdata(dev); > @@ -601,7 +600,6 @@ static int rockchip_pdm_resume(struct device *dev) > > return ret; > } > -#endif > > static const struct dev_pm_ops rockchip_pdm_pm_ops = { > SET_RUNTIME_PM_OPS(rockchip_pdm_runtime_suspend, >