From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0A6FC77B7F for ; Fri, 5 May 2023 16:23:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE0512D4E; Fri, 5 May 2023 18:22:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE0512D4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683303819; bh=6kcrjw0DLQvvG6WoGGAiXsqF+PmsQK6JMuo47Z70X/o=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=CP/GB6gcI6UGwBWCQwA4wrIY6eiR9TreptRWhSZMOWsmiUekQzpbDrwN867oITJU5 eHv+RwH/p8rdcCmWePPvxwvFfmxxoVWieLiDVTeOvnOf0cdjvE/KHPLeP/b34uTu4n thEJN2FXpl9dUv0fgQEY3C82jCFqhOG8KFjDRhjI= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 77BE8F8052D; Fri, 5 May 2023 18:22:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C8D5FF8052D; Fri, 5 May 2023 18:22:19 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 56B48F804B1 for ; Fri, 5 May 2023 18:22:16 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 56B48F804B1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CSbgeI/L; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5wgqK9N5 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DEE4722A58; Fri, 5 May 2023 16:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683303735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iOXD6ZlkZ5fRlViQb5Zd62ZZbZo1N4SCK1XymERkeBs=; b=CSbgeI/LPQx/F64sLJvCROryypbKoVbg2juV+9iV77zqgfoN0cLZaGz62g1xJ39n/I7MYo UZbBUgBpFqTu99rzBI0uto2x/ro+vFex+CVCXKmmx12VC1cjvdA2tkcHfONtpMAhi9Pv24 OcSuSa4xm12fVQMkkmftMJxnVTNciC0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683303735; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iOXD6ZlkZ5fRlViQb5Zd62ZZbZo1N4SCK1XymERkeBs=; b=5wgqK9N5pj5AtxPS74TprLmMcSdwa7ej+oMvLLaGeOpMdQ2T2ns1vqQZZO026rZiS6giDS 3Y1DHdtmBxhxhUCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C024613488; Fri, 5 May 2023 16:22:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jW8oLjctVWQnKAAAMHmgww (envelope-from ); Fri, 05 May 2023 16:22:15 +0000 Date: Fri, 05 May 2023 18:22:15 +0200 Message-ID: <871qjuiw94.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode In-Reply-To: References: <20230505103140.2285622-1-oswald.buddenhagen@gmx.de> <20230505103140.2285622-2-oswald.buddenhagen@gmx.de> <877ctmiyzy.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: MWM2OBDGNXQ6MBZTNLZ2FWL5UGEUSTVU X-Message-ID-Hash: MWM2OBDGNXQ6MBZTNLZ2FWL5UGEUSTVU X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 05 May 2023 17:52:11 +0200, Oswald Buddenhagen wrote: > > On Fri, May 05, 2023 at 05:22:57PM +0200, Takashi Iwai wrote: > > On Fri, 05 May 2023 12:31:35 +0200, > > Oswald Buddenhagen wrote: > >> Suggested-by: Oswald Buddenhagen > >> Signed-off-by: Jaroslav Kysela > >> Reviewed-by: Oswald Buddenhagen > > > > Here misses your Signed-off-by tag. Ditto for the patch 3. > > It's a legal requirement, and I can't apply patches without it. > > > i assumed reviewed-by would be a superset, but apparently it's not. > however, there is no need to add SOB to patches which i only reviewed > or suggested. SOB is needed by a person who submitted, no matter whether any other tags are present. So, it's still mandatory in this case. > i'll adjust the patches to which i made substantial > modifications, though. Great, thanks! Takashi