From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 837C3C77B75 for ; Fri, 5 May 2023 09:24:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9E9292C17; Fri, 5 May 2023 11:23:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9E9292C17 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683278654; bh=9vPhqtgz/qVGgFYbD9UbdKybwsBMkrteVksIhFTGdvg=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kiZHzDbm2q8w0JyBQjTQCPfCIKRtuxKWmSAfxHenRkZBuN/520ooCSw/yrxfjRlOI CyoS0dEW+iMUD1MvzWd88T2mLr123qOZGYIR5EGfLVuUOvxmoyNdZ8T8ggcWP/OcRu hxewW+BPko9VOpBXQ6RGmaAfWFgXgkGVwEjwSNoc= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4DBB1F804B1; Fri, 5 May 2023 11:22:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AEC7AF8052D; Fri, 5 May 2023 11:22:55 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 69EDDF804B1 for ; Fri, 5 May 2023 11:22:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 69EDDF804B1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uJl43poX; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ZyEZBGTh Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 50D391FD87; Fri, 5 May 2023 09:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683278569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/TQQLhq4X72z2eBC+8HjtOU55a4ahnELpSCvb9qoJ9c=; b=uJl43poXTl+54MeX6KIx8rrAs9rK8MkIhDSuZzj0eUrgQekNKIi8KwnNphJUFRsGzGZPcp Ok1ccuKszVIOfsd1qtY/upzUW/pvGcsZNfLoxyV70/h+yvqy+vMMQsM+v00vOtmWLq1OOq JdcrrjsiCDNVnnPELS78vXxkwT9HSj4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683278569; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/TQQLhq4X72z2eBC+8HjtOU55a4ahnELpSCvb9qoJ9c=; b=ZyEZBGThcd9g4vqHLp6Z98zVXzbuFxa0f4th56l21314m2O8bWt5DmZdLRmLNlioaRI/3l PgaiTzr7kbhQPQBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2843613488; Fri, 5 May 2023 09:22:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id btH7COnKVGQKWQAAMHmgww (envelope-from ); Fri, 05 May 2023 09:22:49 +0000 Date: Fri, 05 May 2023 11:22:48 +0200 Message-ID: <871qjvjfo7.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH 0/5] rewrite snd_pcm_playback_silence() again In-Reply-To: <20230505073813.1219175-1-perex@perex.cz> References: <20230505073813.1219175-1-perex@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: FQ62Q7VYAXUYBY6MYZWWLCZDAJ3ISXWN X-Message-ID-Hash: FQ62Q7VYAXUYBY6MYZWWLCZDAJ3ISXWN X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ALSA development , Oswald Buddenhagen , Jeff Chua X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 05 May 2023 09:38:08 +0200, Jaroslav Kysela wrote: > > This is a split of changes for both patches (the first with the missing > top-up mode + later fix with mixups) proposed by Oswald. The aim was to > pick only real code changes. > > Only the first two patches after revert fixes the current silencing issues. > The last two are just cleanups with the extra optimization in the last patch > moving the common code to a function. > > Cc: Oswald Buddenhagen > Cc: Jeff Chua > > Jaroslav Kysela (5): > ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" > ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the > threshold mode > ALSA: pcm: fix playback silence - correct the incremental silencing > ALSA: pcm: playback silence - remove extra code > ALSA: pcm: playback silence - move silence variables updates to > separate function Thanks, this makes it much easier to digest the whole changes! I watch out for a while whether any objection comes up, then apply patches in today -- or if we didn't reach to consensus, I'll pick up only the first revert patch for 6.4-rc1, at least. Takashi