From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57ABDC77B73 for ; Sun, 23 Apr 2023 07:36:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 42702F25; Sun, 23 Apr 2023 09:35:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 42702F25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682235379; bh=E8BT+NmYofB3sbtmuM6azpnkWFSz+gcGqgr7KvhEKYw=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=EXzxpgQPfa1NHix2Ibvp3LZ3aPxZthzn1nQElM85UP+PdcGB0kXHFHK6+LgJFRp6s UZFfumKpQm63/s6cmeGLmEUj8XVuctKx8w0rw3BORd7EyhKy6uEF9DkkElozjOl/uu Iy39Zd/PsTECNxXUZ5ITdOoA2H9QPYMqgrdDEMdM= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7DD57F80236; Sun, 23 Apr 2023 09:35:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47DD4F80236; Sun, 23 Apr 2023 09:34:59 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E379CF80137 for ; Sun, 23 Apr 2023 09:34:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E379CF80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=C6DGisLb; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=He08ft8O Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5E0DD1F8B8; Sun, 23 Apr 2023 07:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682235296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g0MrUeC2kJ1KumSvs3T5H6F5Q6lcEmYSpYhiKpRqEoE=; b=C6DGisLbSIW90h70eRmjwEUShLxL3QdpOfsUgc9HhYpMmFErE+YYR92k0+VyIauGmcU67P WVm0PTEaq3mxe1WNRoZAqk0a/osHZvGh7Ohn4o5PcjxVZ/XFLNfor6kBx2DFa++XtUG9sV QfaAos1Jbkehx+hKWX3+ZBgY0GzGTrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682235296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g0MrUeC2kJ1KumSvs3T5H6F5Q6lcEmYSpYhiKpRqEoE=; b=He08ft8Ot+GV2ZM6sWDQI5ROlY2EXbW3xLrsPsZp7v5va8juPZVD/gnY00HnzVnJgZFrJU qPZNZ6FSLz0WJ6BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3ECDC13498; Sun, 23 Apr 2023 07:34:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UpWODqDfRGT3MgAAMHmgww (envelope-from ); Sun, 23 Apr 2023 07:34:56 +0000 Date: Sun, 23 Apr 2023 09:34:55 +0200 Message-ID: <871qkboxuo.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 1/2] ALSA: emu10k1: fix SNDRV_EMU10K1_IOCTL_SINGLE_STEP In-Reply-To: <20230422161021.1144004-1-oswald.buddenhagen@gmx.de> References: <20230422161021.1144004-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: UGKUE3I47W57FKTJM6YQJU3VESIKQJ25 X-Message-ID-Hash: UGKUE3I47W57FKTJM6YQJU3VESIKQJ25 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 22 Apr 2023 18:10:20 +0200, Oswald Buddenhagen wrote: > > - Use correct address limit for Audigy > - Use the right constant to actually make a step on Audigy > - Don't store *_DBG_STEP and the address in emu->fx8010.dbg, as > otherwise unrelated operations would make steps, too > > This is untested. as10k1 was never ported to Audigy anyway. > > Signed-off-by: Oswald Buddenhagen Applied both patches now. Although 0-day bot caught some build error, I couldn't reproduce it, so took as is. Let's see whether it's broken at some config combo. thanks, Takashi