From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD31BC27C76 for ; Wed, 25 Jan 2023 08:36:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8E937846; Wed, 25 Jan 2023 09:35:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8E937846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674635761; bh=CotTbL/GbV6DXyqyvr+jqQJAYenUBwI8M9CqjuzFIl8=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Q1A6ijEpLXigbHMXMIyrIX059kne+JwhKP6UXau0qVUVYRU/W/Y+Md4PfWE8JCeai U78bXeyjFGdjT34zewcHmyEGn3gAMWfUz8k9MgTr+NDD5Ol09SMTcPIg3bp+nx3jhH IlZ6kWI2YNa41KLN/h/Z49tuUfzsxD5uMm/CwenI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D8565F80424; Wed, 25 Jan 2023 09:35:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E3757F80424; Wed, 25 Jan 2023 09:35:05 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 812A2F800AE for ; Wed, 25 Jan 2023 09:34:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 812A2F800AE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OxrVfJWC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=i+41ZHk6 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5A4A21F3F; Wed, 25 Jan 2023 08:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674635697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4pD6a1vgMmjem91hgO9Kz33HyqN716ma2eR4HQMVYA0=; b=OxrVfJWC87cy+y6BoUA/nMDRFcdVUAHuPxKe+V4fT7rqYCzcT7TX0tg32/CrpG7LNKtu6G WQkGXES8vt/8dy5RObel4J3N60PfGw+6+1LtfOOM53OhKLzQ1ZYR7IZhx2SacMPD7AJQai JKwwwd+oxzMy2Tnl48r5wyx6G1DQtWM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674635697; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4pD6a1vgMmjem91hgO9Kz33HyqN716ma2eR4HQMVYA0=; b=i+41ZHk6O15m/Kk0tgmWrLw3GWqlb8dqX8pvSW8RBZxRluy6pLrnr/kkZUlHcc/VWAJ2q5 2cpWirR+IF6uJOAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9F3921339E; Wed, 25 Jan 2023 08:34:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Uvf9JbHp0GN0ewAAMHmgww (envelope-from ); Wed, 25 Jan 2023 08:34:57 +0000 Date: Wed, 25 Jan 2023 09:34:56 +0100 Message-ID: <871qnjdnbj.wl-tiwai@suse.de> From: Takashi Iwai To: Dawei Li Subject: Re: [PATCH v2] ALSA: ac97: make remove callback of ac97 driver void returned In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 06 Jan 2023 16:13:49 +0100, Dawei Li wrote: > > Since commit fc7a6209d571 ("bus: Make remove callback return void") > forces bus_type::remove be void-returned, it doesn't make much sense > for any bus based driver implementing remove callbalk to return > non-void to its caller. > > As such, change the remove function for ac97 based drivers to return > void. > > Signed-off-by: Dawei Li Applied now, thanks. Takashi