From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7CDCA9EC0 for ; Mon, 28 Oct 2019 20:57:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00502218AC for ; Mon, 28 Oct 2019 20:57:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ggLP+3f+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00502218AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E204620E9; Mon, 28 Oct 2019 21:57:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E204620E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572296273; bh=ziZu47/alsSmVf9/J5lThLqdwQ0llMKBNuxOe5C7s9Y=; h=From:To:References:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ggLP+3f+j522dkcqnnKR6dNrrNiJMCVWhqCMBV4nBVOCxMNOiypqe4xA1YrgwizS9 rKUpOkUH8UzBjUWM9tyn6IPXEIGPBG8dSlVhUJoLgq/iae+k7GWg58yVfsP0cqcrm3 8FhaMyVqL7P8avfFcg5jmuvWu5EkN4EfjtLeIO2I= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6C7B8F8011D; Mon, 28 Oct 2019 21:57:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E7652F802BD; Mon, 28 Oct 2019 21:57:00 +0100 (CET) Received: from smtp.smtpout.orange.fr (smtp09.smtpout.orange.fr [80.12.242.131]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 50564F8011D for ; Mon, 28 Oct 2019 21:56:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 50564F8011D Received: from belgarion ([90.55.204.252]) by mwinf5d17 with ME id K8wx210045TFNlm038wxR7; Mon, 28 Oct 2019 21:56:57 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Oct 2019 21:56:57 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-18-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Oct 2019 21:56:56 +0100 In-Reply-To: <20191018154201.1276638-18-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:33 +0200") Message-ID: <871ruwmvvr.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Mark Brown , Daniel Mack , linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH 18/46] ARM: pxa: corgi: use gpio descriptors for audio X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Arnd Bergmann writes: > The audio driver should not use a hardwired gpio number > from the header. Change it to use a lookup table. > > Cc: Mark Brown > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann > @@ -41,6 +40,8 @@ > static int corgi_jack_func; > static int corgi_spk_func; > > +struct gpio_desc *gpiod_mute_l, *gpiod_mute_r, *gpiod_apm_on, > *gpiod_mic_bias; Can't this be static ? Otherwise : Acked-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel