From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH 2/4 v2] ASoC: simple-card: remove dai_link->cpu_dai_name when DT
Date: Wed, 27 Aug 2014 20:08:06 -0700 (PDT) [thread overview]
Message-ID: <8738chia5n.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <8761hdia86.wl%kuninori.morimoto.gx@gmail.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
f687d900d30a61dda38db2a99239f5284a86a309
(ASoC: simple-card: cpu_dai_name creates confusion when DT case)
removed dai_link->cpu_dai_name when DT case,
since it uses DT phand in soc_bind_dai_link().
This binding will fail if it has cpu_dai_name.
6a91a17bd7b92b2d2aa9ece85457f52a62fd7708
(ASoC: simple-card: Handle many DAI links)
added multi DAI link support to simple-card driver.
Then, removing cpu_dai_name was cared only single DAI.
But, it is needed in all DT cases.
This patch moves it to asoc_simple_card_dai_link_of()
so that care about all DAIs.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
sound/soc/generic/simple-card.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index c5445b0..e8185a0 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -285,6 +285,17 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
dai_props->codec_dai.fmt,
dai_props->codec_dai.sysclk);
+ /*
+ * soc_bind_dai_link() will check cpu name
+ * after of_node matching if dai_link has cpu_dai_name.
+ * but, it will never match if name was created by fmt_single_name()
+ * remove cpu_dai_name to escape name matching.
+ * see
+ * fmt_single_name()
+ * fmt_multiple_name()
+ */
+ dai_link->cpu_dai_name = NULL;
+
dai_link_of_err:
if (np)
of_node_put(np);
@@ -429,18 +440,6 @@ static int asoc_simple_card_probe(struct platform_device *pdev)
goto err;
}
- /*
- * soc_bind_dai_link() will check cpu name
- * after of_node matching if dai_link has cpu_dai_name.
- * but, it will never match if name was created by fmt_single_name()
- * remove cpu_dai_name to escape name matching.
- * see
- * fmt_single_name()
- * fmt_multiple_name()
- */
- if (num_links == 1)
- dai_link->cpu_dai_name = NULL;
-
} else {
struct asoc_simple_card_info *cinfo;
--
1.7.9.5
next prev parent reply other threads:[~2014-08-28 3:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 7:06 [PATCH 0/8] ASoC: simple-card: DPCM support Kuninori Morimoto
[not found] ` <87fvgriqrb.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-20 7:07 ` [PATCH 1/8] ASoC: simple-card: use asoc_simple_xxx prefix Kuninori Morimoto
2014-08-20 7:07 ` [PATCH 2/8] ASoC: simple-card: remove dai_link->cpu_dai_name when DT Kuninori Morimoto
2014-08-20 7:09 ` [PATCH 3/8] ASoC: simple-card: dai_link->init should be cared when multi DAI Kuninori Morimoto
2014-08-20 7:09 ` [PATCH 4/8] ASoC: simple-card: use common for_each_child_of_node() for loop Kuninori Morimoto
2014-08-20 7:11 ` [PATCH 5/8] ASoC: simple-card: add DPCM support when DT case Kuninori Morimoto
2014-08-20 7:11 ` [PATCH 6/8] ASoC: simple-card: remove is_top_level_node from asoc_simple_card_sub_parse_of() Kuninori Morimoto
2014-08-20 7:11 ` [PATCH 7/8] ASoC: rsnd: add dai_link stream name Kuninori Morimoto
2014-08-20 7:13 ` [PATCH 8/8] ASoC: add snd-soc-dummy DT support Kuninori Morimoto
[not found] ` <874mx7iqgt.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-08-24 8:48 ` [alsa-devel] " Lars-Peter Clausen
[not found] ` <53F9A6EE.5070005-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-08-26 0:04 ` Kuninori Morimoto
[not found] ` <871ts4nmki.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-26 6:25 ` Mark Brown
[not found] ` <20140826062558.GR17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-26 8:34 ` Kuninori Morimoto
[not found] ` <87wq9vmyyc.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-26 9:11 ` Mark Brown
[not found] ` <20140826091120.GC17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-26 9:19 ` Lars-Peter Clausen
[not found] ` <53FC5105.6070901-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-08-26 9:42 ` Mark Brown
[not found] ` <20140826094211.GF17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-26 10:31 ` Kuninori Morimoto
[not found] ` <87r403mtip.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-26 10:50 ` Mark Brown
[not found] ` <20140826105028.GK17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-27 1:11 ` Kuninori Morimoto
[not found] ` <87d2bmpwi2.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-27 3:14 ` Kuninori Morimoto
[not found] ` <87a96qpqsy.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-27 8:24 ` Lars-Peter Clausen
[not found] ` <53FD95AB.6080903-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-08-28 0:33 ` Kuninori Morimoto
[not found] ` <87fvghihaq.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-28 7:23 ` Lars-Peter Clausen
[not found] ` <53FED90B.8070308-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-08-28 10:41 ` Kuninori Morimoto
2014-08-28 8:02 ` Mark Brown
[not found] ` <20140828080251.GG17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-08-28 10:56 ` Kuninori Morimoto
[not found] ` <87sikghohq.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-29 0:41 ` Kuninori Morimoto
2014-08-26 0:08 ` [PATCH 0/8] ASoC: simple-card: DPCM support Kuninori Morimoto
[not found] ` <87zjesm7sp.wl%kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-28 3:04 ` Kuninori Morimoto
2014-08-28 3:06 ` [PATCH 0/4 v2] ASoC: simple-card: fixup for DT Kuninori Morimoto
2014-08-28 3:07 ` [PATCH 1/4 v2] ASoC: simple-card: use asoc_simple_xxx prefix Kuninori Morimoto
2014-08-29 11:49 ` Mark Brown
2014-08-28 3:08 ` Kuninori Morimoto [this message]
2014-08-29 11:51 ` [PATCH 2/4 v2] ASoC: simple-card: remove dai_link->cpu_dai_name when DT Mark Brown
2014-08-28 3:08 ` [PATCH 3/4 v2] ASoC: simple-card: dai_link->init should be cared when multi DAI Kuninori Morimoto
2014-08-29 11:51 ` Mark Brown
2014-08-28 3:08 ` [PATCH 4/4 v2] ASoC: simple-card: use common for_each_child_of_node() for loop Kuninori Morimoto
2014-08-29 11:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738chia5n.wl%kuninori.morimoto.gx@gmail.com \
--to=kuninori.morimoto.gx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).