From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F0D6C77B7D for ; Mon, 15 May 2023 13:41:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0687E820; Mon, 15 May 2023 15:40:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0687E820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684158078; bh=YAF1aObMIgXzBYR23f4kLdqR1xrcj0OH5P1lpTvFI1I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FdjYkVZbs5vrbyx6cw37DOCUCH5wV9otYVI9JHPcao7e3i0cpNkD9JQWSpQ5CkFzR efd5EGu1jEVf2RPJpgbaBwmQH/CD4iu2DVJQkaNW8rTEaC4P+dHU5q+7tlEtPfDTyE EzuoMdkxSOvoPGQJObufo5TudTlOO0qqrwYefHlw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9945AF80549; Mon, 15 May 2023 15:40:03 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DAB3CF8016D; Mon, 15 May 2023 15:40:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BD12FF80272; Mon, 15 May 2023 15:39:57 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 262CCF8016D for ; Mon, 15 May 2023 15:39:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 262CCF8016D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BcztabH5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qsVZTHcf Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9C08821C3D; Mon, 15 May 2023 13:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684157990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NdD+9F73a1JS19ma9M2nove4HcijJ9yFsVmb4aGVZcc=; b=BcztabH5QC++MdEKV3K1+zOxP6OWeApIQ4XWGM1A/Fv1EWqLcEXpIPEgzw8FOJHn5gwM2H 24tgUnpuaVNZwwIpLLjOHr3vXjdimWlvmpTC1c9tbZKLltQHbpUAUtz93WXbtXDmHXUC2V RkOM3J3m8iwUiVMKfB/UP1k9M1fy0Eg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684157990; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NdD+9F73a1JS19ma9M2nove4HcijJ9yFsVmb4aGVZcc=; b=qsVZTHcfig2RpF1wQUPUppfHKlCGrvqsgpK912mb5WqDHYJQVJSh7xcX1b4SYkeD3gi8xt h0Oj4wWucaGhzKAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 667EF138E5; Mon, 15 May 2023 13:39:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0X7dFyY2YmSlTQAAMHmgww (envelope-from ); Mon, 15 May 2023 13:39:50 +0000 Date: Mon, 15 May 2023 15:39:49 +0200 Message-ID: <874jodlnmi.wl-tiwai@suse.de> From: Takashi Iwai To: "Joseph C. Sible" Cc: Bagas Sanjaya , regressions@lists.linux.dev, kailang@realtek.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot In-Reply-To: References: <87cz338ix4.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: A24OXICV3MIGIDVVA3FNYDBRNP2VXBKA X-Message-ID-Hash: A24OXICV3MIGIDVVA3FNYDBRNP2VXBKA X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 14 May 2023 23:48:55 +0200, Joseph C. Sible wrote: > > On 5/14/23, Takashi Iwai wrote: > > The patch changes two places (the change in alc_shutup_pins() and > > alc256_shutup()), and I guess the latter is the culprit. Could you > > verify that only reverting the latter fixes the problem? > > Yes, only reverting the latter fixes the problem. I just tried a > kernel consisting of 6.3.2 plus the below change, and it works fine: > > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec *codec) > /* If disable 3k pulldown control for alc257, the Mic > detection will not work correctly > * when booting with headset plugged. So skip setting it for > the codec alc257 > */ > - if (codec->core.vendor_id != 0x10ec0236 && > - codec->core.vendor_id != 0x10ec0257) > + if (codec->core.vendor_id != 0x10ec0257) > alc_update_coef_idx(codec, 0x46, 0, 3 << 12); > > if (!spec->no_shutup_pins) OK, thanks for confirmation. Kailang, could you check this issue? Judging from the comment there: /* 3k pull low control for Headset jack. */ /* NOTE: call this before clearing the pin, otherwise codec stalls */ /* If disable 3k pulldown control for alc257, the Mic detection will not work correctly * when booting with headset plugged. So skip setting it for the codec alc257 */ ... it seems that the codec got screwed with this setup, which leaded to the non-response at the probe after reboot. In the worst case, I'll revert that part. thanks, Takashi