From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1082DC4332F for ; Fri, 4 Nov 2022 07:13:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 48C53163C; Fri, 4 Nov 2022 08:12:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 48C53163C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667545988; bh=PUWdQK3rOzqbwuRdi5nHbCwQDz6H2sHaMf4mm2gn+sY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=teFcy77XgTJ3CcWai28B23lUlLsjtN3nwZOSQJLL4dLlU5Er/Dm55yhUsPQNa0uIO LZHu+Qyv1tjj3LYphElb4ZVsGwUyJX2X9OH4gG4Ckg/fDq4ifdzPl/h4aipQh0FxyH +Tykgihmtl9/pwgTQlJzRvQ1hfHA7Foc/CbSI3ac= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C4457F80431; Fri, 4 Nov 2022 08:12:17 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8CD99F80448; Fri, 4 Nov 2022 08:12:16 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5B6D4F801D5 for ; Fri, 4 Nov 2022 08:12:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5B6D4F801D5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="BY2yVzAC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="qLts6ezm" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74189218EC; Fri, 4 Nov 2022 07:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667545929; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LL81uK+aN/ZrKn6tbUNDzuG9HRl0DQASNkhSw6+aLmc=; b=BY2yVzACwB90mWdPCYz9d1X1ku3aW2bk2FO9Yu5vxQm6npnMNtZl1aYwbb46dxqr/FgZlY qe4rb+eRmnHQesf5UrL3l9qvYiug0UFfIBRMNIwJF5toSpNzXV64vnzE+kHQWu7g8quftc 5UiY/nexb4sebI8xITrB4AJA/b55EoE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667545929; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LL81uK+aN/ZrKn6tbUNDzuG9HRl0DQASNkhSw6+aLmc=; b=qLts6ezm1XNxQFDyHqVvR55kcHURKxjLzrqNpVRIWPX+eU9HMhpsCjEX8BY9VrA7qrs3HA oIsnsCVCxOJqU1Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 53FFC1346F; Fri, 4 Nov 2022 07:12:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EkfRE0m7ZGMwOgAAMHmgww (envelope-from ); Fri, 04 Nov 2022 07:12:09 +0000 Date: Fri, 04 Nov 2022 08:12:08 +0100 Message-ID: <874jvfkxbr.wl-tiwai@suse.de> From: Takashi Iwai To: aichao Subject: Re: [PATCH] ALSA: usb-audio: fix usb camero disconnect issue In-Reply-To: <20221104013236.3480427-1-aichao@kylinos.cn> References: <20221104013236.3480427-1-aichao@kylinos.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 04 Nov 2022 02:32:36 +0100, aichao wrote: > > When current rate is different from the runtime rate, > snd_usb_endpoint stop and close endpoint to resetting rate. > if snd_usb_endpoint close the endpoint, sometimes usb will > disconnect the device. What do you mean...? snd_usb_endpoint_close() never disconnects the device by itself. Please elaborate the problem. Takashi > > Signed-off-by: aichao > --- > sound/usb/pcm.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c > index 5dc9266180e3..2ae4a55cbaa8 100644 > --- a/sound/usb/pcm.c > +++ b/sound/usb/pcm.c > @@ -517,7 +517,6 @@ static int snd_usb_hw_params(struct snd_pcm_substream *substream, > if (snd_usb_endpoint_compatible(chip, subs->data_endpoint, > fmt, hw_params)) > goto unlock; > - close_endpoints(chip, subs); > } > > subs->data_endpoint = snd_usb_endpoint_open(chip, fmt, hw_params, false); > @@ -546,9 +545,6 @@ static int snd_usb_hw_params(struct snd_pcm_substream *substream, > ret = configure_endpoints(chip, subs); > > unlock: > - if (ret < 0) > - close_endpoints(chip, subs); > - > snd_usb_unlock_shutdown(chip); > stop_pipeline: > if (ret < 0) > @@ -574,7 +570,6 @@ static int snd_usb_hw_free(struct snd_pcm_substream *substream) > if (!snd_usb_lock_shutdown(chip)) { > if (stop_endpoints(subs)) > sync_pending_stops(subs); > - close_endpoints(chip, subs); > snd_usb_unlock_shutdown(chip); > } > > -- > 2.25.1 >