From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 772B9C19F2C for ; Tue, 16 Aug 2022 06:05:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 409F9868; Tue, 16 Aug 2022 08:04:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 409F9868 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1660629940; bh=hoiHJHv+fdUsrFL+BpcB94R7A2792UnoLLGExXkO4TI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=f8Au3mY54nqWGN5wxhq2SsdU/x2uBcHULwps5oNC/LglTo/ti6eJyFaS8kcItt4LO yJqR7ykKqe4T5dI1wBN/4yzKIzwH9fMsuZ9XUgOhgW7yMOA631ZE8vKK662f3o5koK cgJdAglG6gMuk2haXejmZGO3xjm2b/FaKkCk6dwM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D383FF80118; Tue, 16 Aug 2022 08:04:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3BC6BF8032D; Tue, 16 Aug 2022 08:04:48 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5F776F80118 for ; Tue, 16 Aug 2022 08:04:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5F776F80118 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rgC87uJV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OMWB+2UU" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A6C0A3823F; Tue, 16 Aug 2022 06:04:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1660629884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=12yHrPLyIFmjXZoB0vLhJ9YWMdxlx4Ue/DTpR8lbBS8=; b=rgC87uJVyuNSjWDxla9j/ihTzFJ1VSld85Q+8//1nMapA+PTaJP7faDMSM4z3dW+iVvrGL hu7CKqebi/r7Md2bRF8jhSSHHYuicUAIfEZRdXTQjeLi149w6H/NaCDdNEg68kVDIsZ/wu B2wXGUdo2OITur3lIPTPoOzlgMMI/g8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1660629884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=12yHrPLyIFmjXZoB0vLhJ9YWMdxlx4Ue/DTpR8lbBS8=; b=OMWB+2UUcfTrgdkYZo69b4ezTUAF8SbdLtAYpmoSKR/t0doCrabE5v/2ITxJd/7NSb7SM/ og8+8NeWRug9p6BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C7AF1345B; Tue, 16 Aug 2022 06:04:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fLWhIXwz+2IYJwAAMHmgww (envelope-from ); Tue, 16 Aug 2022 06:04:44 +0000 Date: Tue, 16 Aug 2022 08:04:44 +0200 Message-ID: <874jyczptv.wl-tiwai@suse.de> From: Takashi Iwai To: mbarriolinares Subject: Re: [PATCH] Add quirk to enable Avid Mbox 3 support In-Reply-To: <20220816004427.7117-1-mbarriolinares@gmail.com> References: <20220417025459.8105-1-connerknoxpublic@gmail.com> <20220816004427.7117-1-mbarriolinares@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, tiwai@suse.com, connerknoxpublic@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 16 Aug 2022 02:44:27 +0200, mbarriolinares wrote: > > > Hi all, > > > > I believe these are the right emails to send this patch to, > > but if I've missed something please let me know. > > > > This patch enables the Avid Mbox 3 audio interface to > > be used through ALSA. It locks the device at a 48khz sample rate. > > Then it mutes and raises the appropriate channels/inputs to allow > > for expected functionality. > > > > Thanks for your time. > > Thanks Conner for taking the time to write and submit this! > > I have an MBox 3 (USB) and I've tested the patch: > > 1. Have not tested S/PDIF i/o because I don't have hardware to plug it. > 2. Output is in mono. It seems the monitor outputs work only in MONO. > (with and without the front mono button switched on or off). > 3. Haven't tested if Headphones output work in stereo because I don't > have hardware for testing. > 3. Inputs work great. > > I'll get a stereo 1/4'' jack to 3.5mm for testing the headphones out. > You can contact me directly if needed. It seems that I overlooked this patch some how. Through a quick glance, the patch needs the proper Signed-off-by line, at least, for merging to the upstream. Also, simple memset() with zero could be used for clearing the com_buf. Otherwise, it's fine to apply as long as the stuff works more or less (at least improving things). thanks, Takashi