From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB446C43334 for ; Sat, 9 Jul 2022 16:51:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D67D91EA; Sat, 9 Jul 2022 18:50:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D67D91EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657385501; bh=DftDdpxBMqZDiVTj9zRLsLTASeFcrz47ITkEmcTMjFY=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=REeEAyyscpMkGINTtHy1jhOCjFAP1eOGLsouBQUA2HZ2qYmFF70n4G+hsZAZooQtU wPXeNER4gkl63RD66ATr7BLdCHimmBg0lzvQsR47VOhJkh8IGlkM9spkaNWwcEtKpf nZDWEDNjPnhtH8tuzXNIGx4Q+mPRw4CGVvLED93E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 724D0F8020D; Sat, 9 Jul 2022 18:50:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76CCEF80166; Sat, 9 Jul 2022 18:50:49 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 021EDF80166 for ; Sat, 9 Jul 2022 18:50:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 021EDF80166 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fReeCo2U"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="E2dpivmK" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD87221F78; Sat, 9 Jul 2022 16:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657385446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h1cwZHnc8M+Avfl14vI7UBicXlGI7LYCAz+gHf34Fes=; b=fReeCo2UN01fOK406RLK9pDbSatZnSNPkn9c7IMacz8ieHl/t2aap+aLyHrYzXLQcmOYux lZqdiNTlBAbNShDH5EbeefsRJ6RljAeJXL6/6uBi26PAg99y89ZNzjHl3MOD1zkYCpCjlm WVEWjS/IslBhDOBaJNMonoOKEK5i9V0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657385446; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h1cwZHnc8M+Avfl14vI7UBicXlGI7LYCAz+gHf34Fes=; b=E2dpivmKtM1gHqswBuwcwzkX1SE9kAjt5gXEpsKh3+94Pzv1IIk8ufZWWvBCHYzc4sPtP4 i+K8b3NSfxQWIpBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E26013482; Sat, 9 Jul 2022 16:50:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8jTgJeaxyWKUagAAMHmgww (envelope-from ); Sat, 09 Jul 2022 16:50:46 +0000 Date: Sat, 09 Jul 2022 18:50:46 +0200 Message-ID: <874jzqi61l.wl-tiwai@suse.de> From: Takashi Iwai To: Cezary Rojewski Subject: Re: [PATCH 0/9] ALSA: hda: Codec-reload bug fixes and cleanups In-Reply-To: <20220706120230.427296-1-cezary.rojewski@intel.com> References: <20220706120230.427296-1-cezary.rojewski@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 06 Jul 2022 14:02:21 +0200, Cezary Rojewski wrote: > > Total of 6 fixes and 3 cleanups - cleanups are last. > > All of the fixes address problems that present themselves in situation > when user engages in codec driver reload. Second condition to reproduce > is two-step initialization of HDAudio codec - this is the case only for > ASoC HDAudio bus driver as snd_hda_intel calls only compound function > snd_hda_codec_new(). Once these conditions are met, several > reload/unload scenarios end with null-ptr-deref and page faults. Goal of > the series is to allow codec/bus driver reloading without any errors. > > Amadeusz Sławiński (2): > ALSA: hda: Reset all SIE bits in INTCTL > ALSA: hda: Remove unused macro definition > > Cezary Rojewski (7): > ALSA: hda: Do not unset preset when cleaning up codec > ALSA: hda: Fix null-ptr-deref when i915 fails and hdmi is denylisted > ALSA: hda: Make device usage_count consistent across subsequent > probing > ALSA: hda: Fix put_device() inconsistency in error path > ALSA: hda: Skip event processing for unregistered codecs > ALSA: hda: Fix page fault in snd_hda_codec_shutdown() > ALSA: hda/realtek: Remove redundant init_hook() in alc_default_init() Now applied partially what are applicable and look correct: patches 2, 3, 4, 6, 7, and 8. Patch 5 waits for Mark's PR of ASoC changes, and patch 1 needs a bit more clarification and investigation. thanks, Takashi