From: Peter Korsgaard <peter@korsgaard.com>
To: kbuild test robot <lkp@intel.com>
Cc: Songjun Wu <songjun.wu@atmel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
nicolas.ferre@atmel.com, Liam Girdwood <lgirdwood@gmail.com>,
broonie@kernel.org, kbuild-all@01.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings
Date: Mon, 28 Sep 2015 13:26:46 +0200 [thread overview]
Message-ID: <874miekcnd.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20150928091029.GA23312@roam> (kbuild test robot's message of "Mon, 28 Sep 2015 17:10:29 +0800")
>>>>> "kbuild" == kbuild test robot <lkp@intel.com> writes:
> sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
> PTR_ERR should access the value just tested by IS_ERR
> Semantic patch information:
> There can be false positives in the patch case, where it is the call
> IS_ERR that is wrong.
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> CC: Songjun Wu <songjun.wu@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> atmel-classd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
dd-> gclk = devm_clk_get(dev, "gclk");
> if (IS_ERR(dd->aclk)) {
> - ret = PTR_ERR(dd->gclk);
> + ret = PTR_ERR(dd->aclk);
It looks like it is the other way around. It should test
IS_ERR(dd->gclk) instead.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2015-09-28 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 5:14 [RESEND PATCH v2 0/2] ASoC: atmel-classd: add driver for Atmel CLASSD Songjun Wu
2015-09-28 5:14 ` [RESEND PATCH v2 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu
2015-09-28 9:10 ` [PATCH] ASoC: atmel-classd: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-09-28 9:10 ` [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings kbuild test robot
2015-09-28 11:26 ` Peter Korsgaard [this message]
2015-09-29 1:42 ` [alsa-devel] " Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874miekcnd.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kbuild-all@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nicolas.ferre@atmel.com \
--cc=songjun.wu@atmel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox