From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DD69CD3447 for ; Tue, 19 Sep 2023 07:20:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 669829F6; Tue, 19 Sep 2023 09:19:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 669829F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1695108037; bh=H8eXLHda69Y2V4neWax6GqafceoDgBk1hDkOthWyHmo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=l60Kf+qCweE99Wv2JF7p2uzF1aiWgUIhX4DPEzWWEcIfyqVibwF48qgwrM+txVhN6 o1/drcbq+1Nlag4w4hhpMPETRqm3d41TLHA1BI8bffCiTbj3ReaE80oZmp5toBVgLO O4wIIvJlru9iGrI2BDC3Gwi7+mwklQ7x11iR4bf8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B3AFF80552; Tue, 19 Sep 2023 09:19:27 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E06D7F80549; Tue, 19 Sep 2023 09:19:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 09A2BF8025A; Tue, 19 Sep 2023 09:19:23 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 87B52F80124 for ; Tue, 19 Sep 2023 09:19:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 87B52F80124 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DM8I+8Lz; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=zHDux32B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E4A1922932; Tue, 19 Sep 2023 07:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695107956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GG6y4FHqXeSp66aca2nlPw1ZWsHbZZ+yBsWdUIsgJvM=; b=DM8I+8LzdUDh37+/t0awvJkMty3cj8lVeJaq86wqWA9kCqHJZhuS8mPV5bGVJWDMQh5PC0 HouWFwJFOcchFRj+3fELbyp6lvhFmiQZq4tcJ7EsQ+U41g0wodLVoqdsellvNAanO1dLJP WVu0H86yiZetme1Nwvf+2hDVohwUPBg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695107956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GG6y4FHqXeSp66aca2nlPw1ZWsHbZZ+yBsWdUIsgJvM=; b=zHDux32B3laadN0cd9vAbKBRGeZMzk4kDDL0+sKPfGuua80Cy9qvA9TiooD5lSBPA4BNOw m9T6Q5Mo6bGIP5Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BF877134F3; Tue, 19 Sep 2023 07:19:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nm7eLXRLCWXuaAAAMHmgww (envelope-from ); Tue, 19 Sep 2023 07:19:16 +0000 Date: Tue, 19 Sep 2023 09:19:16 +0200 Message-ID: <875y46zl3f.wl-tiwai@suse.de> From: Takashi Iwai To: Peter Ujfalusi Cc: tiwai@suse.com, perex@perex.cz, alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: usb-audio: scarlett_gen2: Fix another -Wformat-truncation warning In-Reply-To: <20230919071205.10684-1-peter.ujfalusi@linux.intel.com> References: <20230919071205.10684-1-peter.ujfalusi@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: BRIZBDXQOXHH3HEL5STVST2THTFF4MQF X-Message-ID-Hash: BRIZBDXQOXHH3HEL5STVST2THTFF4MQF X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 19 Sep 2023 09:12:05 +0200, Peter Ujfalusi wrote: > > The recent enablement of -Wformat-truncation leads to a false-positive > warning for mixer_scarlett_gen2.c. > > For suppressing the warning, replace snprintf() with scnprintf(). > As stated in the above, truncation doesn't matter. > > Fixes: 78bd8f5126f8 ("ALSA: usb-audio: scarlett_gen2: Fix -Wformat-truncation warning") > Signed-off-by: Peter Ujfalusi While I applied it now, I wonder why this didn't show up with my local test. Which compiler are you using? thanks, Takashi