From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 952F4C7EE22 for ; Wed, 17 May 2023 20:20:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8C8AA200; Wed, 17 May 2023 22:19:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8C8AA200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684354801; bh=Dvtv8pSNHd/3p5/ADg/iz7hVB6G/ZTgzwrKg3ZudzmM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=LnRGwZXFCHg19P09ZZft3b5ORZlyCQRltlt5TjgCNvC8OaQsjmPWAR3uPjp1a7bJO bEWd9KiH+unXx62IzsXGy4i71r765l5LRajXMFfkCTENFfieJJcMNJ9D2nOYes9bYQ 48FabHOmJozFIth1Sme3wl12uZJIQyZAhGkZKVkI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id B269DF80544; Wed, 17 May 2023 22:19:02 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 132BBF8024E; Wed, 17 May 2023 22:19:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E7B5FF80272; Wed, 17 May 2023 22:18:57 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E9D96F8016A for ; Wed, 17 May 2023 22:18:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E9D96F8016A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iaLtxLKX; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LtLmmsnu Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A14B22622; Wed, 17 May 2023 20:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684354731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+mR/qksS6Sq/MuwYCqpKG165oYMDJK2AcyjLgtwP+o=; b=iaLtxLKXpNzj1ha+SarH32AT6FiIOtMRdJ5hsRazR17dz2ZLjJ8TuxtjBwHUmS9moFIaj3 nFj9DFlYrIf9GUWM16CpZZgcDzGZOI8t70nrym/VNI9efLOHuc6PesTcbWcOp75UuJ+pAu nFUJs+YFy+V7pN6jMtNxSYRrL8pBs1U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684354731; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v+mR/qksS6Sq/MuwYCqpKG165oYMDJK2AcyjLgtwP+o=; b=LtLmmsnuuXapwVhJs1Hvwyv8+BQ0GOiTfyP/wCVevaeYR5Xh+hh1qZ5NxPeW49KjzkNYqy 92eFQWZNpd+QGaDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0C48E13478; Wed, 17 May 2023 20:18:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EBJhAas2ZWSABAAAMHmgww (envelope-from ); Wed, 17 May 2023 20:18:51 +0000 Date: Wed, 17 May 2023 22:18:50 +0200 Message-ID: <875y8q1zkl.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Christophe Leroy , Naresh Kamboju Subject: Re: [PATCH] ALSA: emu10k1: remove runtime 64-bit divisions In-Reply-To: <20230517164800.3650699-1-oswald.buddenhagen@gmx.de> References: <20230517164800.3650699-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: OLO7CTZBLH4CQQZZR46QWJJ7UYCRMASN X-Message-ID-Hash: OLO7CTZBLH4CQQZZR46QWJJ7UYCRMASN X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 17 May 2023 18:48:00 +0200, Oswald Buddenhagen wrote: > > 32-bit platforms don't like these. As we're actually dealing with > constants, factor out the calculations and pass them in as additional > arguments. To keep the call sites clean, wrap the actual functions in > macros which generate the arguments. > > Fixes: bb5ceb43b7bf ("ALSA: emu10k1: fix non-zero mixer control defaults in highres mode") > Fixes: 1298bc978afb ("ALSA: emu10k1: enable bit-exact playback, part 1: DSP attenuation") > Signed-off-by: Oswald Buddenhagen > > --- > > Cc: Christophe Leroy > Cc: Naresh Kamboju > --- Thanks, applied now. Takashi