From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DB95C48260 for ; Mon, 19 Feb 2024 08:29:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 62653839; Mon, 19 Feb 2024 09:29:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 62653839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1708331357; bh=erH4/v2CKMxgJZ8lHD4k+yf1CAwK7bi6Lj8v/IlFaJM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=EK55k/vn08k7m9rtaLxZ7fYVGhfQY5ssBOQR/kctyPKRx4vEobo/RFiyMECm7vJz9 O1+kxUEILhNlznrD55UeggEYMlOWxwce+jO0ok2RXKQExuIt3d5Z2Lctfehifcz6p8 7NITszIVaH5Vm8jYWL17G5vxCDYAF7kcAXz7zDM0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29E3FF805D6; Mon, 19 Feb 2024 09:28:25 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9A064F805BA; Mon, 19 Feb 2024 09:28:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F173F80496; Mon, 19 Feb 2024 09:26:15 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E4DDDF8019B for ; Mon, 19 Feb 2024 09:26:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E4DDDF8019B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e+nlVF1a; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lLQF3Clv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e+nlVF1a; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lLQF3Clv Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4B53921C14; Mon, 19 Feb 2024 08:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708331171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L1oTvsJEC0RW4pZVI6O3To2ANPqP0P6uuo0vISwSHEE=; b=e+nlVF1aepKag0Vwi9L/ims0suRJs/Wu45zHcyeztTbsp1qJy/Yr4+yzX3FKXFRqDcqFug baQaITMFbkXebvyYBniaVW6kO9G+My7nTT8oIhRkuVrCegZbM6ob5sqjldmwmHz/L0m22E 1HlKJqFHbGHV7SKcXxUT2oxTU5WE5EA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708331171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L1oTvsJEC0RW4pZVI6O3To2ANPqP0P6uuo0vISwSHEE=; b=lLQF3ClvkZaINHpfiqbOlDeZDJzJQ1UIEofXsSxt8glJKBIQ+3Y40aGieF0XiXEHILWfCR Dx91VHYno1TDFZBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708331171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L1oTvsJEC0RW4pZVI6O3To2ANPqP0P6uuo0vISwSHEE=; b=e+nlVF1aepKag0Vwi9L/ims0suRJs/Wu45zHcyeztTbsp1qJy/Yr4+yzX3FKXFRqDcqFug baQaITMFbkXebvyYBniaVW6kO9G+My7nTT8oIhRkuVrCegZbM6ob5sqjldmwmHz/L0m22E 1HlKJqFHbGHV7SKcXxUT2oxTU5WE5EA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708331171; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L1oTvsJEC0RW4pZVI6O3To2ANPqP0P6uuo0vISwSHEE=; b=lLQF3ClvkZaINHpfiqbOlDeZDJzJQ1UIEofXsSxt8glJKBIQ+3Y40aGieF0XiXEHILWfCR Dx91VHYno1TDFZBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2752D13647; Mon, 19 Feb 2024 08:26:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id jfwMCKMQ02U1BQAAD6G6ig (envelope-from ); Mon, 19 Feb 2024 08:26:11 +0000 Date: Mon, 19 Feb 2024 09:26:10 +0100 Message-ID: <877cj0q2ql.wl-tiwai@suse.de> From: Takashi Iwai To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: firewire-lib: fix to check cycle continuity In-Reply-To: <20240218033026.72577-1-o-takashi@sakamocchi.jp> References: <20240218033026.72577-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e+nlVF1a; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=lLQF3Clv X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.09 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.58)[98.15%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4B53921C14 Message-ID-Hash: 7FYLJVI6XWXVVRIWXIWYAKTTHRWG2GHG X-Message-ID-Hash: 7FYLJVI6XWXVVRIWXIWYAKTTHRWG2GHG X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 18 Feb 2024 04:30:26 +0100, Takashi Sakamoto wrote: > > The local helper function to compare the given pair of cycle count > evaluates them. If the left value is less than the right value, the > function returns negative value. > > If the safe cycle is less than the current cycle, it is the case of > cycle lost. However, it is not currently handled properly. > > This commit fixes the bug. > > Cc: > Fixes: 705794c53b00 ("ALSA: firewire-lib: check cycle continuity") > Signed-off-by: Takashi Sakamoto Thanks, applied. Takashi