From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD92EC001E0 for ; Wed, 19 Jul 2023 10:47:01 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2F1401F6; Wed, 19 Jul 2023 12:46:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2F1401F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689763619; bh=syvtk7zaVF4ZrTVMDXgN66zgszFkmrBWw+8lqc/s7bY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Yr1irv+YnRNJQBb+NCwhFhPGVMJ2d1eAOBtyVAo+nHyOP42dDdQvMrtouYsZcQMrO vQ1e9iqa+tsbNaWJQAI8rau7FbQBkMucEIwzakHC6uTiWv3x4304sen9rkCUHqGFq/ 7qt5MrP0XxvY2q9v+NGDQX4Ch+VraypRvmvr1fj4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 15CE1F80153; Wed, 19 Jul 2023 12:45:43 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 781C8F8047D; Wed, 19 Jul 2023 12:45:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 51AAAF8047D; Wed, 19 Jul 2023 12:45:37 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EB4F3F80153 for ; Wed, 19 Jul 2023 12:45:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EB4F3F80153 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oWnAzfPg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dV2bHC1O Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3B9EA21AF6; Wed, 19 Jul 2023 10:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689763529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DrA2Bw7h8WRsl+OM17dKZ5uDDe5qDZ9+jVDVL6tab/8=; b=oWnAzfPgU4q10QbwM9fM7ElQvU4gpWYCofDVbODyTxomKKtZQCa0Mxj9GILcR9fZUDZCCn 6ISVAZuW0QzRpJUhkue1vcutpSENY7e0lF6t3x98JfVFDKrKHQkkC07Ns/ZYcqHrTTtrPO NGebZnNCzJBhZnRz0EGslVmYskKSUTU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689763529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DrA2Bw7h8WRsl+OM17dKZ5uDDe5qDZ9+jVDVL6tab/8=; b=dV2bHC1O8uBzgBSDcRrkVP2kQceJR7pIVw19LuJ3YvyNyO21hiHi+D8gmWeM6us397Zkxo t4RNVXWF37mjQlBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F5041361C; Wed, 19 Jul 2023 10:45:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ySQZC8m+t2TbSQAAMHmgww (envelope-from ); Wed, 19 Jul 2023 10:45:29 +0000 Date: Wed, 19 Jul 2023 12:45:28 +0200 Message-ID: <877cqwji2f.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Cc: alsa-devel@alsa-project.org Subject: Re: [PATCH 10/11] ALSA: control: Take lock in snd_ctl_find_id() and snd_ctl_find_numid() In-Reply-To: References: <20230718141304.1032-1-tiwai@suse.de> <20230718141304.1032-11-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: J6JDPQLSNTRUI7EM5P3VSPCAV6TEMNX5 X-Message-ID-Hash: J6JDPQLSNTRUI7EM5P3VSPCAV6TEMNX5 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 19 Jul 2023 12:20:18 +0200, Oswald Buddenhagen wrote: > > On Tue, Jul 18, 2023 at 04:13:03PM +0200, Takashi Iwai wrote: > > Now all needed callers have been replaced with *_locked() versions, > > > i don't understand why you made that a separate patch, given that > there is no separate conversion step in between. i'd just squash it > into the parent, and also absorb the followup commit. The logic is that the first patch does the API function rename and replaces the existing calls in 1:1 manner, while the second patch replaces the open code in emu10k1. Takashi