From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode
Date: Fri, 05 May 2023 17:22:57 +0200 [thread overview]
Message-ID: <877ctmiyzy.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230505103140.2285622-2-oswald.buddenhagen@gmx.de>
On Fri, 05 May 2023 12:31:35 +0200,
Oswald Buddenhagen wrote:
>
> From: Jaroslav Kysela <perex@perex.cz>
>
> The snd_pcm_playback_hw_avail() function uses runtime->status->hw_ptr.
> Unfortunately, in case when we call this function from snd_pcm_update_hw_ptr0(),
> this variable contains the previous hardware pointer. Use the new_hw_ptr
> argument to calculate hw_avail (filled samples by the user space) to
> correct the threshold comparison.
>
> The new_hw_ptr argument may also be set to ULONG_MAX which means the
> initialization phase. In this case, use runtime->status->hw_ptr.
>
> Suggested-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Here misses your Signed-off-by tag. Ditto for the patch 3.
It's a legal requirement, and I can't apply patches without it.
Could you resubmit the series quickly with your SOB?
thanks,
Takashi
next prev parent reply other threads:[~2023-05-05 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 10:31 [PATCH 1/7] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode Oswald Buddenhagen
2023-05-05 15:22 ` Takashi Iwai [this message]
2023-05-05 15:52 ` Oswald Buddenhagen
2023-05-05 16:22 ` Takashi Iwai
2023-05-05 16:32 ` Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 3/7] ALSA: pcm: fix playback silence - correct incremental silencing Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 4/7] ALSA: pcm: playback silence - remove extra code Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 5/7] ALSA: pcm: playback silence - move silence variable updates to separate function Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 6/7] ALSA: pcm: simplify top-up mode init in snd_pcm_playback_silence() Oswald Buddenhagen
2023-05-05 10:31 ` [PATCH 7/7] ALSA: pcm: use exit controlled loop " Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ctmiyzy.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox