From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 7/7] ALSA: emu10k1: use more existing defines instead of open-coded numbers
Date: Sun, 23 Apr 2023 09:26:47 +0200 [thread overview]
Message-ID: <877cu3oy88.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230422161021.1143903-8-oswald.buddenhagen@gmx.de>
On Sat, 22 Apr 2023 18:10:21 +0200,
Oswald Buddenhagen wrote:
>
> Using the *_MASK defines for "maximal value" is debatable. I got the
> idea from FreeBSD, and it sorta makes sense to me.
>
> Some hunks look a bit incomplete, because code that is going to be
> subsequently removed is not touched here.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
This patch actually broke the build due to A_I2S_CAPTURE_RATE, as
0-day bot caught. Any missing patch?
thanks,
Takashi
next prev parent reply other threads:[~2023-04-23 7:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 16:10 [PATCH 0/7] ALSA: emu10k1: improvements mostly related to #defines Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 1/7] ALSA: emu10k1: comment updates Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 2/7] ALSA: emu10k1: fix lineup of EMU_HANA_* defines Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 3/7] ALSA: emu10k1: eliminate some unused defines Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 4/7] ALSA: emu10k1: remove some bogus defines Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 5/7] ALSA: emu10k1: pull in some register definitions from kX-project Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 6/7] ALSA: emu10k1: fixup DSP defines Oswald Buddenhagen
2023-04-22 16:10 ` [PATCH 7/7] ALSA: emu10k1: use more existing defines instead of open-coded numbers Oswald Buddenhagen
2023-04-22 18:52 ` kernel test robot
2023-04-23 7:26 ` Takashi Iwai [this message]
2023-04-24 13:51 ` Oswald Buddenhagen
2023-04-23 7:27 ` [PATCH 0/7] ALSA: emu10k1: improvements mostly related to #defines Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cu3oy88.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox